mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2025-08-23 05:58:26 +08:00
refactor(components): update components to match stencil style guide
https://github.com/ionic-team/stencil/blob/master/STYLE_GUIDE.md
This commit is contained in:
@ -28,7 +28,7 @@ export class Slide {
|
||||
};
|
||||
}
|
||||
|
||||
protected render() {
|
||||
render() {
|
||||
return <slot></slot>;
|
||||
}
|
||||
}
|
||||
|
@ -185,7 +185,7 @@ export class Slides {
|
||||
@Prop() keyboardControl: boolean;
|
||||
|
||||
|
||||
protected render() {
|
||||
render() {
|
||||
return (
|
||||
<div class='swiper-container' data-dir='rtl'>
|
||||
<div class='swiper-wrapper'>
|
||||
@ -386,9 +386,9 @@ export class Slides {
|
||||
/**
|
||||
* @hidden
|
||||
*/
|
||||
protected ionViewDidLoad() {
|
||||
componentDidLoad() {
|
||||
/**
|
||||
* TODO: This should change because currently ionViewDidLoad fires independent of whether the
|
||||
* TODO: This should change because currently componentDidLoad fires independent of whether the
|
||||
* child components are ready.
|
||||
*/
|
||||
setTimeout(() => {
|
||||
@ -547,7 +547,7 @@ export class Slides {
|
||||
/**
|
||||
* @hidden
|
||||
*/
|
||||
protected ionViewDidUnload() {
|
||||
componentDidUnload() {
|
||||
this._init = false;
|
||||
|
||||
this.swiper.destroy(true, true);
|
||||
|
Reference in New Issue
Block a user