mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2025-08-21 13:01:01 +08:00
docs(contributing): updates gulp commands
This commit is contained in:
6
.github/CONTRIBUTING.md
vendored
6
.github/CONTRIBUTING.md
vendored
@ -40,8 +40,8 @@ Looking for an issue to fix? Make sure to look through our issues with the [help
|
|||||||
#### TypeScript Changes
|
#### TypeScript Changes
|
||||||
|
|
||||||
1. If there is a `*.spec.ts` file located in the `test/` folder, update it to include a karma test for your change, if needed. If this file doesn't exist, please notify us.
|
1. If there is a `*.spec.ts` file located in the `test/` folder, update it to include a karma test for your change, if needed. If this file doesn't exist, please notify us.
|
||||||
2. Run `gulp karma` to make sure all tests are working, regardless if a test was added.
|
2. Run `gulp test` to make sure all tests are working, regardless if a test was added.
|
||||||
3. Run `gulp tslint` and fix any linter errors.
|
3. Run `gulp lint.ts` and fix any linter errors.
|
||||||
|
|
||||||
|
|
||||||
#### Sass Changes
|
#### Sass Changes
|
||||||
@ -57,7 +57,7 @@ Looking for an issue to fix? Make sure to look through our issues with the [help
|
|||||||
|
|
||||||
#### Viewing Changes
|
#### Viewing Changes
|
||||||
|
|
||||||
1. Run the gulp watch task for e2e tests: `gulp watch.e2e`
|
1. Run the gulp watch task for e2e tests: `gulp e2e.watch`
|
||||||
2. Launch your browser and navigate to `http://localhost:8000/dist/e2e`
|
2. Launch your browser and navigate to `http://localhost:8000/dist/e2e`
|
||||||
3. From here, navigate to the component you are changing.
|
3. From here, navigate to the component you are changing.
|
||||||
4. Any changes to the e2e tests in the `test/` directory will show here.
|
4. Any changes to the e2e tests in the `test/` directory will show here.
|
||||||
|
Reference in New Issue
Block a user