javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-20 12:29:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

perf(animation): set after styles should not be recursive

Browse Source
This commit is contained in:
Manu Mtz.-Almeida
2016-11-16 13:41:54 +01:00
parent a7042e37c2
commit 3a2ff85f6a
1 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/animations/animation.ts
View File

@ -414,7 +414,7 @@ export class Animation {
// since there was no animation, immediately run the after // since there was no animation, immediately run the after
// ******** DOM WRITE **************** // ******** DOM WRITE ****************
this._afterAnimation(); this._setAfterStyles();
// this animation has no duration, so it has finished // this animation has no duration, so it has finished
// other animations could still be running // other animations could still be running
@ -513,7 +513,7 @@ export class Animation {
// set the after styles // set the after styles
// ******** DOM WRITE **************** // ******** DOM WRITE ****************
this._afterAnimation(); this._setAfterStyles();
// remove the will-change properties // remove the will-change properties
// ******** DOM WRITE **************** // ******** DOM WRITE ****************
@ -789,13 +789,8 @@ export class Animation {
/** /**
* @private * @private
* DOM WRITE * DOM WRITE
* RECURSION
*/ */
_afterAnimation() { _setAfterStyles() {
for (var i = 0; i < this._cL; i++) {
this._c[i]._afterAnimation();
}
let ele: HTMLElement; let ele: HTMLElement;
for (var i = 0; i < this._eL; i++) { for (var i = 0; i < this._eL; i++) {
ele = this._e[i]; ele = this._e[i];
@ -991,7 +986,7 @@ export class Animation {
// ******** DOM WRITE **************** // ******** DOM WRITE ****************
this._progress(stepValue); this._progress(stepValue);
this._willChg(false); this._willChg(false);
this._afterAnimation(); this._setAfterStyles();
this._didFinish(shouldComplete); this._didFinish(shouldComplete);
} else { } else {