javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 00:27:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(vue): popover positioning is now correct with custom elements build (#23680)

Browse Source
This commit is contained in:
Liam DeBeasi
2021-07-26 09:26:20 -04:00
committed by GitHub
parent df24c8c5ae
commit 3a1a9cbce4
1 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
core/src/utils/transition/index.ts
View File

@ -2,7 +2,7 @@ import { Build, writeTask } from '@stencil/core';
import { LIFECYCLE_DID_ENTER, LIFECYCLE_DID_LEAVE, LIFECYCLE_WILL_ENTER, LIFECYCLE_WILL_LEAVE } from '../../components/nav/constants'; import { LIFECYCLE_DID_ENTER, LIFECYCLE_DID_LEAVE, LIFECYCLE_WILL_ENTER, LIFECYCLE_WILL_LEAVE } from '../../components/nav/constants';
import { Animation, AnimationBuilder, NavDirection, NavOptions } from '../../interface'; import { Animation, AnimationBuilder, NavDirection, NavOptions } from '../../interface';
import { componentOnReady } from '../helpers'; import { componentOnReady, raf } from '../helpers';
const iosTransitionAnimation = () => import('./ios.transition'); const iosTransitionAnimation = () => import('./ios.transition');
const mdTransitionAnimation = () => import('./md.transition'); const mdTransitionAnimation = () => import('./md.transition');
@ -205,6 +205,19 @@ export const deepReady = async (el: any | undefined): Promise<void> => {
if (stencilEl != null) { if (stencilEl != null) {
return; return;
} }
/**
* Custom elements in Stencil will have __registerHost.
*/
} else if (element.__registerHost != null) {
/**
* Non-lazy loaded custom elements need to wait
* one frame for component to be loaded.
*/
const waitForCustomElement = new Promise(resolve => raf(resolve));
await waitForCustomElement;
return;
} }
await Promise.all(Array.from(element.children).map(deepReady)); await Promise.all(Array.from(element.children).map(deepReady));
} }