javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 00:27:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(input, textarea): bottom content is rendered correctly (#26739)

Browse Source 
resolves #26737
This commit is contained in:
Liam DeBeasi
2023-02-07 10:11:52 -05:00
committed by GitHub
parent 92b06f2eb6
commit 39009ac6ef
276 changed files with 81 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
core/src/components/input/input.tsx
View File

@ -1,14 +1,14 @@
import type { ComponentInterface, EventEmitter } from '@stencil/core';
import { Build, Component, Element, Event, Host, Method, Prop, State, Watch, h } from '@stencil/core';
import { createLegacyFormController } from '@utils/forms';
import type { LegacyFormController } from '@utils/forms';
import { printIonWarning } from '@utils/logging';
import { closeCircle, closeSharp } from 'ionicons/icons';
import { getIonMode } from '../../global/ionic-global';
import type { AutocompleteTypes, Color, StyleEventDetail, TextFieldTypes } from '../../interface';
import type { LegacyFormController } from '../../utils/forms';
import { createLegacyFormController } from '../../utils/forms';
import type { Attributes } from '../../utils/helpers';
import { inheritAriaAttributes, debounceEvent, findItemLabel, inheritAttributes } from '../../utils/helpers';
import { printIonWarning } from '../../utils/logging';
import { createColorClasses, hostContext } from '../../utils/theme';
import type { InputChangeEventDetail, InputInputEventDetail } from './input-interface';
@ -564,7 +564,11 @@ export class Input implements ComponentInterface {
private renderBottomContent() {
const { counter, helperText, errorText, maxlength } = this;
const hasHintText = helperText !== undefined || errorText !== undefined;
/**
* undefined and empty string values should
* be treated as not having helper/error text.
*/
const hasHintText = !!helperText || !!errorText;
const hasCounter = counter === true && maxlength !== undefined;
if (!hasHintText && !hasCounter) {
return;