javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 00:27:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

test(datetime): reduce flakiness (#27549)

Browse Source 
Issue number: N/A

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->
Sometimes the datetime picker hasn't scrolled to the correct date yet
before the screenshot is taken. (See JIRA ticket for a failing build.)

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- The test waits until the picker has scrolled before taking the
screenshot.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
Hopefully this is all that's needed. I did a few runs and it hasn't
failed, but it's hard to know with flaky tests 🙃
This commit is contained in:
Shawn Taylor
2023-05-30 15:19:08 -04:00
committed by GitHub
parent 99bb59b2e6
commit 38d05b0fc5
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
core/src/components/datetime/test/prefer-wheel/datetime.e2e.ts
View File

@ -16,36 +16,36 @@ configs().forEach(({ title, screenshot, config }) => {
}); });
}); });
// TODO FW-4110 test('should not have visual regressions for date wheel', async ({ page }) => {
test.skip('should not have visual regressions for date wheel', async ({ page }) => {
await page.setContent( await page.setContent(
` `
<ion-datetime size="cover" presentation="date" prefer-wheel="true" value="2019-05-30" max="2022"></ion-datetime> <ion-datetime size="cover" presentation="date" prefer-wheel="true" value="2019-05-30" max="2022"></ion-datetime>
`, `,
config config
); );
await page.waitForSelector('.datetime-ready');
await expect(page).toHaveScreenshot(screenshot(`datetime-wheel-date-diff`)); await expect(page).toHaveScreenshot(screenshot(`datetime-wheel-date-diff`));
}); });
// TODO FW-4110 test('should not have visual regressions for date-time wheel', async ({ page }) => {
test.skip('should not have visual regressions for date-time wheel', async ({ page }) => {
await page.setContent( await page.setContent(
` `
<ion-datetime size="cover" presentation="date-time" prefer-wheel="true" value="2019-05-30T16:30:00" max="2022"></ion-datetime> <ion-datetime size="cover" presentation="date-time" prefer-wheel="true" value="2019-05-30T16:30:00" max="2022"></ion-datetime>
`, `,
config config
); );
await page.waitForSelector('.datetime-ready');
await expect(page).toHaveScreenshot(screenshot(`datetime-wheel-date-time-diff`)); await expect(page).toHaveScreenshot(screenshot(`datetime-wheel-date-time-diff`));
}); });
// TODO FW-4110 test('should not have visual regressions for time-date wheel', async ({ page }) => {
test.skip('should not have visual regressions for time-date wheel', async ({ page }) => {
await page.setContent( await page.setContent(
` `
<ion-datetime size="cover" presentation="time-date" prefer-wheel="true" value="2019-05-30T16:30:00" max="2022"></ion-datetime> <ion-datetime size="cover" presentation="time-date" prefer-wheel="true" value="2019-05-30T16:30:00" max="2022"></ion-datetime>
`, `,
config config
); );
await page.waitForSelector('.datetime-ready');
await expect(page).toHaveScreenshot(screenshot(`datetime-wheel-time-date-diff`)); await expect(page).toHaveScreenshot(screenshot(`datetime-wheel-time-date-diff`));
}); });