From 35c1adf10c8cafbfe70be92701dc28747694ea2e Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Tue, 14 Jun 2022 09:49:42 -0400 Subject: [PATCH] docs(modal, popover): improve showBackdrop clarity (#25462) --- core/src/components.d.ts | 8 ++++---- core/src/components/modal/modal.tsx | 4 ++++ core/src/components/popover/popover.tsx | 4 ++++ 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/core/src/components.d.ts b/core/src/components.d.ts index 0f5a90487d..e0450fd5f3 100644 --- a/core/src/components.d.ts +++ b/core/src/components.d.ts @@ -1600,7 +1600,7 @@ export namespace Components { */ "setCurrentBreakpoint": (breakpoint: number) => Promise; /** - * If `true`, a backdrop will be displayed behind the modal. + * If `true`, a backdrop will be displayed behind the modal. This property controls whether or not the backdrop darkens the screen when the modal is presented. It does not control whether or not the backdrop is active or present in the DOM. */ "showBackdrop": boolean; /** @@ -1966,7 +1966,7 @@ export namespace Components { */ "reference": PositionReference; /** - * If `true`, a backdrop will be displayed behind the popover. + * If `true`, a backdrop will be displayed behind the popover. This property controls whether or not the backdrop darkens the screen when the popover is presented. It does not control whether or not the backdrop is active or present in the DOM. */ "showBackdrop": boolean; /** @@ -5528,7 +5528,7 @@ declare namespace LocalJSX { */ "presentingElement"?: HTMLElement; /** - * If `true`, a backdrop will be displayed behind the modal. + * If `true`, a backdrop will be displayed behind the modal. This property controls whether or not the backdrop darkens the screen when the modal is presented. It does not control whether or not the backdrop is active or present in the DOM. */ "showBackdrop"?: boolean; /** @@ -5816,7 +5816,7 @@ declare namespace LocalJSX { */ "reference"?: PositionReference; /** - * If `true`, a backdrop will be displayed behind the popover. + * If `true`, a backdrop will be displayed behind the popover. This property controls whether or not the backdrop darkens the screen when the popover is presented. It does not control whether or not the backdrop is active or present in the DOM. */ "showBackdrop"?: boolean; /** diff --git a/core/src/components/modal/modal.tsx b/core/src/components/modal/modal.tsx index 68ed71e222..766423a948 100644 --- a/core/src/components/modal/modal.tsx +++ b/core/src/components/modal/modal.tsx @@ -166,6 +166,10 @@ export class Modal implements ComponentInterface, OverlayInterface { /** * If `true`, a backdrop will be displayed behind the modal. + * This property controls whether or not the backdrop + * darkens the screen when the modal is presented. + * It does not control whether or not the backdrop + * is active or present in the DOM. */ @Prop() showBackdrop = true; diff --git a/core/src/components/popover/popover.tsx b/core/src/components/popover/popover.tsx index 5dafe64f28..4237443911 100644 --- a/core/src/components/popover/popover.tsx +++ b/core/src/components/popover/popover.tsx @@ -128,6 +128,10 @@ export class Popover implements ComponentInterface, PopoverInterface { /** * If `true`, a backdrop will be displayed behind the popover. + * This property controls whether or not the backdrop + * darkens the screen when the popover is presented. + * It does not control whether or not the backdrop + * is active or present in the DOM. */ @Prop() showBackdrop = true;