javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-20 20:33:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(item-sliding): account for swipe to go back gesture when opening item-options (#20777)

Browse Source 
fixes #20773
This commit is contained in:
Liam DeBeasi
2020-03-17 11:00:38 -04:00
committed by GitHub
parent e2df046eff
commit 3514dd8362
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
core/src/components/item-sliding/item-sliding.tsx
View File

@ -73,7 +73,7 @@ export class ItemSliding implements ComponentInterface {
gestureName: 'item-swipe', gestureName: 'item-swipe',
gesturePriority: 100, gesturePriority: 100,
threshold: 5, threshold: 5,
canStart: () => this.canStart(), canStart: ev => this.canStart(ev),
onStart: () => this.onStart(), onStart: () => this.onStart(),
onMove: ev => this.onMove(ev), onMove: ev => this.onMove(ev),
onEnd: ev => this.onEnd(ev), onEnd: ev => this.onEnd(ev),
@ -225,7 +225,18 @@ export class ItemSliding implements ComponentInterface {
this.sides = sides; this.sides = sides;
} }
private canStart(): boolean { private canStart(gesture: GestureDetail): boolean {
/**
* If very close to start of the screen
* do not open left side so swipe to go
* back will still work.
*/
const rtl = document.dir === 'rtl';
const atEdge = (rtl) ? (window.innerWidth - gesture.startX) < 15 : gesture.startX < 15;
if (atEdge) {
return false;
}
const selected = openSlidingItem; const selected = openSlidingItem;
if (selected && selected !== this.el) { if (selected && selected !== this.el) {
this.closeOpened(); this.closeOpened();