diff --git a/core/src/components/loading/readme.md b/core/src/components/loading/readme.md index 609abb394f..713d9f4c3c 100644 --- a/core/src/components/loading/readme.md +++ b/core/src/components/loading/readme.md @@ -10,7 +10,7 @@ Loading indicators can be created using a [Loading Controller](../loading-contro ### Dismissing -The loading indicator can be dismissed automatically after a specific amount of time by passing the number of milliseconds to display it in the `duration` of the loading options. To dismiss the loading indicator after creation, call the `dismiss()` method on the loading instance. The `ionLoadingDidDismiss` event can be listened to in order to perform an action after the loading indicator is dismissed. +The loading indicator can be dismissed automatically after a specific amount of time by passing the number of milliseconds to display it in the `duration` of the loading options. To dismiss the loading indicator after creation, call the `dismiss()` method on the loading instance. The `onDidDismiss` function can be called to perform an action after the loading indicator is dismissed. @@ -21,7 +21,7 @@ The loading indicator can be dismissed automatically after a specific amount of ### Angular ```typescript -import { Component, HostListener } from '@angular/core'; +import { Component } from '@angular/core'; import { LoadingController } from '@ionic/angular'; @Component({ @@ -37,7 +37,11 @@ export class LoadingExample { message: 'Hellooo', duration: 2000 }); - return await loading.present(); + await loading.present(); + + const { role, data } = await loading.onDidDismiss(); + + console.log('Loading dismissed!'); } async presentLoadingWithOptions() { @@ -50,11 +54,6 @@ export class LoadingExample { }); return await loading.present(); } - - @HostListener('document:ionLoadingDidDismiss', ['$event']) - onDidDismiss(event: CustomEvent) { - console.log('Loading dismissed!'); - } } ``` @@ -71,11 +70,11 @@ async function presentLoading() { duration: 2000 }); - loading.addEventListener('ionLoadingDidDismiss', (e) => { - console.log('Loading dismissed!'); - }); + await loading.present(); + + const { role, data } = await loading.onDidDismiss(); - return await loading.present(); + console.log('Loading dismissed!'); } async function presentLoadingWithOptions() { diff --git a/core/src/components/loading/usage/angular.md b/core/src/components/loading/usage/angular.md index fa3dcb1123..5cd21cd3ff 100644 --- a/core/src/components/loading/usage/angular.md +++ b/core/src/components/loading/usage/angular.md @@ -1,5 +1,5 @@ ```typescript -import { Component, HostListener } from '@angular/core'; +import { Component } from '@angular/core'; import { LoadingController } from '@ionic/angular'; @Component({ @@ -15,7 +15,11 @@ export class LoadingExample { message: 'Hellooo', duration: 2000 }); - return await loading.present(); + await loading.present(); + + const { role, data } = await loading.onDidDismiss(); + + console.log('Loading dismissed!'); } async presentLoadingWithOptions() { @@ -28,10 +32,5 @@ export class LoadingExample { }); return await loading.present(); } - - @HostListener('document:ionLoadingDidDismiss', ['$event']) - onDidDismiss(event: CustomEvent) { - console.log('Loading dismissed!'); - } } ``` diff --git a/core/src/components/loading/usage/javascript.md b/core/src/components/loading/usage/javascript.md index 78f781d468..b49dcd0a16 100644 --- a/core/src/components/loading/usage/javascript.md +++ b/core/src/components/loading/usage/javascript.md @@ -8,11 +8,11 @@ async function presentLoading() { duration: 2000 }); - loading.addEventListener('ionLoadingDidDismiss', (e) => { - console.log('Loading dismissed!'); - }); + await loading.present(); + + const { role, data } = await loading.onDidDismiss(); - return await loading.present(); + console.log('Loading dismissed!'); } async function presentLoadingWithOptions() {