From 3226ec7ec6b94fb2acac8f9aeca995c3380b1776 Mon Sep 17 00:00:00 2001 From: Tim Lancina Date: Fri, 5 Feb 2016 10:47:12 -0600 Subject: [PATCH] chore(): tell gulp when finished building --- gulpfile.js | 6 +++--- scripts/README.md | 2 -- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/gulpfile.js b/gulpfile.js index 2b27270d09..32974f98df 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -284,8 +284,7 @@ gulp.task('sass', function() { }); /** - * I'm not quite sure what this is for, people tell me we use it internally to - * test themes. + * Creates Ionic themes for testing. */ gulp.task('sass.themes', function() { var sass = require('gulp-sass'); @@ -776,7 +775,8 @@ gulp.task('build.release', function(done){ runSequence( 'clean', 'copy.libs', - ['bundle', 'sass', 'fonts', 'copy.scss'] + ['bundle', 'sass', 'fonts', 'copy.scss'], + done ); }); diff --git a/scripts/README.md b/scripts/README.md index 96c791d668..515869b4b9 100644 --- a/scripts/README.md +++ b/scripts/README.md @@ -50,8 +50,6 @@ To remove the linked version of `ionic-framework` do `npm rm ionic-framework`, a 3. Export `IONIC_SNAPSHOT_KEY` (get from someone) 4. Run `gulp snapshot` -For more information on protractor, see https://angular.github.io/protractor/#/. - ### Running Tests