javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-15 09:34:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(vue): improve compatibility with route guards (#22371)

Browse Source 
resolves #22344
This commit is contained in:
Liam DeBeasi
2020-10-22 11:03:58 -04:00
committed by GitHub
parent 561a4ac535
commit 31f9bc81d6
6 changed files with 69 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
packages/vue-router/src/router.ts
View File

@ -1,7 +1,6 @@
import {
Router,
RouteLocationNormalized,
NavigationGuardNext
RouteLocationNormalized
} from 'vue-router';
import { createLocationHistory } from './locationHistory';
import { generateId } from './utils';
@ -19,13 +18,20 @@ import { AnimationBuilder } from '@ionic/core';
export const createIonRouter = (opts: IonicVueRouterOptions, router: Router) => {
let currentNavigationInfo: NavigationInformation = { direction: undefined, action: undefined };
router.beforeEach((to: RouteLocationNormalized, _: RouteLocationNormalized, next: NavigationGuardNext) => {
/**
* Ionic Vue should only react to navigation
* changes once they have been confirmed and should
* never affect the outcome of navigation (with the
* exception of going back or selecting a tab).
* As a result, we should do our work in afterEach
* which is fired once navigation is confirmed
* and any user guards have run.
*/
router.afterEach((to: RouteLocationNormalized, _: RouteLocationNormalized) => {
const { direction, action } = currentNavigationInfo;
handleHistoryChange(to, action, direction);
currentNavigationInfo = { direction: undefined, action: undefined };
next();
});
const locationHistory = createLocationHistory();