javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-20 20:33:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(vue): improve compatibility with route guards (#22371)

Browse Source 
resolves #22344
This commit is contained in:
Liam DeBeasi
2020-10-22 11:03:58 -04:00
committed by GitHub
parent 561a4ac535
commit 31f9bc81d6
6 changed files with 69 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
packages/vue/test-app/tests/e2e/specs/routing.js
View File

@ -62,7 +62,23 @@ describe('Routing', () => {
cy.ionPageDoesNotExist('routingparameter');
cy.ionPageVisible('routing');
})
});
// Verifies fix for https://github.com/ionic-team/ionic-framework/issues/22359
it('should work properly with async navigation guards', () => {
cy.visit('http://localhost:8080');
cy.get('#delayed-redirect').click();
cy.get('ion-loading').should('exist');
cy.ionPageVisible('routing');
cy.ionPageHidden('home');
cy.ionBackClick('routing');
cy.ionPageVisible('home');
cy.ionPageDoesNotExist('routing');
});
});
describe('Routing - Swipe to Go Back', () => {

9
packages/vue/test-app/tests/e2e/specs/tabs.js
View File

@ -113,6 +113,15 @@ describe('Tabs', () => {
cy.get('ion-tab-button#tab-button-tab2').click();
cy.ionPageVisible('tab2');
});
// Verifies fix for https://github.com/ionic-team/ionic-framework/issues/22344
it('should show tab 1 when redirecting from tab 3', () => {
cy.visit('http://localhost:8080/tabs/tab3');
cy.ionPageVisible('tab1');
cy.ionPageDoesNotExist('tab3');
cy.ionPageVisible('tabs');
});
})
describe('Tabs - Swipe to Go Back', () => {