javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-20 04:14:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(overlays): make them hidden until presented (#16903)

Browse Source 
fixes #16685
This commit is contained in:
Manu MA
2018-12-29 01:31:33 +01:00
committed by GitHub
parent 3d656ac312
commit 302be5392c
25 changed files with 35 additions and 219 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
core/src/utils/overlays.ts
View File

@ -9,7 +9,7 @@ export function createOverlay<T extends HTMLIonOverlayElement>(element: T, opts:
// convert the passed in overlay options into props
// that get passed down into the new overlay
Object.assign(element, opts);
element.classList.add('ion-page-invisible');
element.classList.add('overlay-hidden');
const overlayIndex = lastId++;
element.overlayIndex = overlayIndex;
if (!element.hasAttribute('id')) {
@ -142,7 +142,7 @@ async function overlayAnimation(
} else {
// Make overlay visible in case it's hidden
baseEl.classList.remove('ion-page-invisible');
baseEl.classList.remove('overlay-hidden');
const aniRoot = baseEl.shadowRoot || overlay.el;
const animation = overlay.animation = await import('./animation').then(mod => mod.create(animationBuilder, aniRoot, opts));