javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-18 19:21:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(range): gesture is now properly re-created on connectedCallback (#22407)

Browse Source 
resolves #22335
This commit is contained in:
Liam DeBeasi
2020-11-02 10:50:08 -05:00
committed by GitHub
parent 27191026ef
commit 2fea36fc98
1 changed files with 30 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
core/src/components/range/range.tsx
View File

@ -28,6 +28,7 @@ import { createColorClasses, hostContext } from '../../utils/theme';
})
export class Range implements ComponentInterface {
private didLoad = false;
private noUpdate = false;
private rect!: ClientRect;
private hasFocus = false;
@ -177,20 +178,7 @@ export class Range implements ComponentInterface {
*/
@Event() ionBlur!: EventEmitter<void>;
connectedCallback() {
this.updateRatio();
this.debounceChanged();
this.disabledChanged();
}
disconnectedCallback() {
if (this.gesture) {
this.gesture.destroy();
this.gesture = undefined;
}
}
async componentDidLoad() {
private setupGesture = async () => {
const rangeSlider = this.rangeSlider;
if (rangeSlider) {
this.gesture = (await import('../../utils/gesture')).createGesture({
@ -206,6 +194,34 @@ export class Range implements ComponentInterface {
}
}
componentDidLoad() {
this.setupGesture();
this.didLoad = true;
}
connectedCallback() {
this.updateRatio();
this.debounceChanged();
this.disabledChanged();
/**
* If we have not yet rendered
* ion-range, then rangeSlider is not defined.
* But if we are moving ion-range via appendChild,
* then rangeSlider will be defined.
*/
if (this.didLoad) {
this.setupGesture();
}
}
disconnectedCallback() {
if (this.gesture) {
this.gesture.destroy();
this.gesture = undefined;
}
}
private handleKeyboard = (knob: KnobName, isIncrease: boolean) => {
let step = this.step;
step = step > 0 ? step : 1;