javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(all): use ts strict mode

Browse Source
This commit is contained in:
Manu Mtz.-Almeida
2018-02-05 18:34:37 +01:00
parent 513b0216dd
commit 2f8a027e2f
35 changed files with 3630 additions and 293 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
packages/core/src/components/virtual-scroll/test/basic.html
View File

@@ -15,10 +15,17 @@
<ion-header>
<ion-toolbar>
<ion-title>Ionic CDN demo</ion-title>
<ion-buttons slot="end">
<ion-button onclick="addItems()">Add Items</ion-button>
</ion-buttons>
</ion-toolbar>
</ion-header>
<ion-content>
<p>
<ion-button onclick="addItems()">Add Items</ion-button>
</p>
<ion-virtual-scroll id="virtual"></ion-virtual-scroll>
</ion-content>
@@ -27,6 +34,10 @@
</ion-app>
<script>
function addItems() {
const virtual = document.getElementById('virtual');
virtual.addItems()
}
async function init() {
const virtual = await document.getElementById('virtual').componentOnReady();
virtual.itemHeight = () => 45;

22
packages/core/src/components/virtual-scroll/virtual-scroll.tsx
View File

@@ -11,7 +11,7 @@ import { Cell, DomRenderFn, HeaderFn, ItemHeightFn, ItemRenderFn, NodeHeightFn,
})
export class VirtualScroll {
private scrollEl: HTMLElement;
private scrollEl: HTMLElement | null;
private range: Range = {offset: 0, length: 0};
private timerUpdate: any;
private heightIndex: Uint32Array;
@@ -145,7 +145,7 @@ export class VirtualScroll {
private updateVirtualScroll() {
// do nothing if there is a scheduled update
if (!this.isEnabled) {
if (!this.isEnabled || !this.scrollEl) {
return;
}
if (this.timerUpdate) {
@@ -155,13 +155,15 @@ export class VirtualScroll {
this.dom.read(() => {
let topOffset = 0;
let node = this.el;
while (node !== this.scrollEl) {
let node: HTMLElement | null = this.el;
while (node && node !== this.scrollEl) {
topOffset += node.offsetTop;
node = node.parentElement;
}
this.viewportOffset = topOffset;
this.currentScrollTop = this.scrollEl.scrollTop;
if (this.scrollEl) {
this.currentScrollTop = this.scrollEl.scrollTop;
}
});
this.dom.write(() => {
@@ -276,11 +278,15 @@ export class VirtualScroll {
}
private calcDimensions() {
this.viewportHeight = this.scrollEl.offsetHeight;
if (this.scrollEl) {
this.viewportHeight = this.scrollEl.offsetHeight;
}
}
private enableScrollEvents(shouldListen: boolean) {
this.isEnabled = shouldListen;
this.enableListener(this, 'scroll', shouldListen, this.scrollEl);
if (this.scrollEl) {
this.isEnabled = shouldListen;
this.enableListener(this, 'scroll', shouldListen, this.scrollEl);
}
}
}