javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-15 17:42:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(react): create a new overlay each time component is presented, fixes #19841, #19823 (#19842)

Browse Source
This commit is contained in:
Ely Lucas
2019-11-05 16:49:10 -07:00
committed by Ely Lucas
parent e5e9dd5dfe
commit 2f5d823748
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/react/src/components/createControllerComponent.tsx
View File

@ -54,18 +54,15 @@ export const createControllerComponent = <OptionsType extends object, OverlayTyp
async present(prevProps?: Props) { async present(prevProps?: Props) {
const { isOpen, onDidDismiss, ...cProps } = this.props; const { isOpen, onDidDismiss, ...cProps } = this.props;
let overlay = this.overlay; this.overlay = await controller.create({
if (!overlay) {
overlay = this.overlay = await controller.create({
...cProps as any ...cProps as any
}); });
} attachProps(this.overlay, {
attachProps(overlay, {
[dismissEventName]: onDidDismiss [dismissEventName]: onDidDismiss
}, prevProps); }, prevProps);
// Check isOpen again since the value could of changed during the async call to controller.create // Check isOpen again since the value could of changed during the async call to controller.create
if (this.props.isOpen === true) { if (this.props.isOpen === true) {
await overlay.present(); await this.overlay.present();
} }
} }