diff --git a/packages/core/src/components/action-sheet/action-sheet.tsx b/packages/core/src/components/action-sheet/action-sheet.tsx index 0af6d98e79..228f61423c 100644 --- a/packages/core/src/components/action-sheet/action-sheet.tsx +++ b/packages/core/src/components/action-sheet/action-sheet.tsx @@ -292,13 +292,15 @@ export class ActionSheet { class={this.buttonClass(cancelButton)} onClick={() => this.buttonClick(cancelButton)} > - {cancelButton.icon - ? - : null} - {cancelButton.text} + + {cancelButton.icon + ? + : null} + {cancelButton.text} + diff --git a/packages/core/src/components/action-sheet/test/basic/index.html b/packages/core/src/components/action-sheet/test/basic/index.html index 40809109a0..d5a3eab83b 100644 --- a/packages/core/src/components/action-sheet/test/basic/index.html +++ b/packages/core/src/components/action-sheet/test/basic/index.html @@ -21,6 +21,7 @@ Basic + Icons No Backdrop Dismiss Alert from Action Sheet Scrollable Options @@ -37,6 +38,45 @@ async function presentBasic() { const mode = Ionic.mode; + const actionSheetController = document.querySelector('ion-action-sheet-controller'); + await actionSheetController.componentOnReady(); + const actionSheetElement = await actionSheetController.create({ + title: "Albums", + buttons: [{ + text: 'Delete', + role: 'destructive', + handler: () => { + console.log('Delete clicked'); + } + }, { + text: 'Share', + handler: () => { + console.log('Share clicked'); + } + }, { + text: 'Play (open modal)', + handler: () => { + console.log('Play clicked'); + } + }, { + text: 'Favorite', + handler: () => { + console.log('Favorite clicked'); + } + }, { + text: 'Cancel', + role: 'cancel', + handler: () => { + console.log('Cancel clicked'); + } + }] + }) + await actionSheetElement.present(); + } + + async function presentIcons() { + const mode = Ionic.mode; + const actionSheetController = document.querySelector('ion-action-sheet-controller'); await actionSheetController.componentOnReady(); const actionSheetElement = await actionSheetController.create({ @@ -62,14 +102,14 @@ } }, { text: 'Favorite', - icon: mode !== 'ios' ? 'heart' : null, + icon: 'heart', handler: () => { console.log('Favorite clicked'); } }, { text: 'Cancel', role: 'cancel', - icon: mode !== 'ios' ? 'close' : null, + icon: 'close', handler: () => { console.log('Cancel clicked'); }