javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-09 16:16:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(header): large title transition works on older versions of iOS (#21339)

Browse Source
This commit is contained in:
David
2020-05-27 16:34:01 +02:00
committed by GitHub
parent 7703da28f8
commit 2dac12c577
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
core/src/components/header/header.tsx
View File

@ -64,6 +64,13 @@ export class Header implements ComponentInterface {
const pageEl = this.el.closest('ion-app,ion-page,.ion-page,page-inner'); const pageEl = this.el.closest('ion-app,ion-page,.ion-page,page-inner');
const contentEl = (pageEl) ? pageEl.querySelector('ion-content') : null; const contentEl = (pageEl) ? pageEl.querySelector('ion-content') : null;
// Cloned elements are always needed in iOS transition
writeTask(() => {
const title = cloneElement('ion-title') as HTMLIonTitleElement;
title.size = 'large';
cloneElement('ion-back-button');
});
await this.setupCollapsibleHeader(contentEl, pageEl); await this.setupCollapsibleHeader(contentEl, pageEl);
} }
} }
@ -127,10 +134,6 @@ export class Header implements ComponentInterface {
this.scrollEl!.addEventListener('scroll', this.contentScrollCallback); this.scrollEl!.addEventListener('scroll', this.contentScrollCallback);
writeTask(() => { writeTask(() => {
const title = cloneElement('ion-title') as HTMLIonTitleElement;
title.size = 'large';
cloneElement('ion-back-button');
if (this.collapsibleMainHeader !== undefined) { if (this.collapsibleMainHeader !== undefined) {
this.collapsibleMainHeader.classList.add('header-collapse-main'); this.collapsibleMainHeader.classList.add('header-collapse-main');
} }