mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2025-08-18 03:00:58 +08:00
fix(angular): remove invalid z-index style (#27559)
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The Angular implementation of `ion-tabs` uses SASS styles in the inline usage for styles: ```ts styles: [` :host { z-index: $z-index-page-container; } `] ``` However Angular is expecting CSS mark-up by default. This results in an invalid value being assigned to the `z-index`.  ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Removes the invalid style from the tabs stylesheet - Removes unnecessary leading whitespace from the template ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
This commit is contained in:
@ -8,7 +8,7 @@ import { StackEvent } from './stack-utils';
|
|||||||
|
|
||||||
@Component({
|
@Component({
|
||||||
selector: 'ion-tabs',
|
selector: 'ion-tabs',
|
||||||
template: ` <ng-content select="[slot=top]"></ng-content>
|
template: `<ng-content select="[slot=top]"></ng-content>
|
||||||
<div class="tabs-inner">
|
<div class="tabs-inner">
|
||||||
<ion-router-outlet #outlet tabs="true" (stackEvents)="onPageSelected($event)"></ion-router-outlet>
|
<ion-router-outlet #outlet tabs="true" (stackEvents)="onPageSelected($event)"></ion-router-outlet>
|
||||||
</div>
|
</div>
|
||||||
@ -29,7 +29,6 @@ import { StackEvent } from './stack-utils';
|
|||||||
height: 100%;
|
height: 100%;
|
||||||
|
|
||||||
contain: layout size style;
|
contain: layout size style;
|
||||||
z-index: $z-index-page-container;
|
|
||||||
}
|
}
|
||||||
.tabs-inner {
|
.tabs-inner {
|
||||||
position: relative;
|
position: relative;
|
||||||
|
Reference in New Issue
Block a user