javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-06 22:29:44 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(react): overlay hooks memorised properly to prevent re-renders (#24010)

Browse Source 
resolves #23741

Co-authored-by: Fabrice <fabrice@weinberg.me>
This commit is contained in:
Ely Lucas
2021-10-05 06:44:40 -06:00
committed by GitHub
parent f112ad4490
commit 2c97712601
11 changed files with 276 additions and 146 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
packages/react/src/hooks/useIonPicker.tsx
View File

@ -1,9 +1,5 @@
import {
PickerButton,
PickerColumn,
PickerOptions,
pickerController,
} from '@ionic/core';
import { PickerButton, PickerColumn, PickerOptions, pickerController } from '@ionic/core';
import { useCallback } from 'react';
import { HookOverlayOptions } from './HookOverlayOptions';
import { useController } from './useController';
@ -18,12 +14,10 @@ export function useIonPicker(): UseIonPickerResult {
pickerController
);
function present(columns: PickerColumn[], buttons?: PickerButton[]): void;
function present(options: PickerOptions & HookOverlayOptions): void;
function present(
const present = useCallback((
columnsOrOptions: PickerColumn[] | (PickerOptions & HookOverlayOptions),
buttons?: PickerButton[]
) {
) => {
if (Array.isArray(columnsOrOptions)) {
controller.present({
columns: columnsOrOptions,
@ -32,7 +26,7 @@ export function useIonPicker(): UseIonPickerResult {
} else {
controller.present(columnsOrOptions);
}
}
}, [controller.present]);
return [present, controller.dismiss];
}