diff --git a/CHANGELOG.md b/CHANGELOG.md index 3e5bfbafb5..46a03358e8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -437,23 +437,25 @@ page-selector-you-added { 27. Update `tsconfig.json` to match [ionic2-app-base](https://github.com/driftyco/ionic2-app-base/blob/master/tsconfig.json). -28. Modify `theme/` folder to delete the `app.core.scss` file and copy `app.variables.scss` from the [ionic2-app-base](https://github.com/driftyco/ionic2-app-base/blob/master/src/theme/variables.scss), then rename it to `variables.scss`. +28. Rename and relocate `app/theme/app.variables.scss` to `src/theme/variables.scss`. -29. Move any variables from the mode specific files into the `app.variables` file under the mode heading. +29. Move app Sass rule files from `app/theme` to `src/app`. This includes `app.core.scss`, `app.ios.scss`, etc. -30. Fix any paths to images in your app. For example, before the path may look like `` and now it should be ``. +30. Move any variables from the mode specific files into the `theme/variables.scss` file. -31. Change any uses of the `private` TypeScript keyword to `public` ONLY for component variables that are needed in the associated template. +31. Fix any paths to images in your app. For example, before the path may look like `` and now it should be ``. + +32. Change any uses of the `private` TypeScript keyword to `public` ONLY for component variables that are needed in the associated template. Note: For details as to why this change has to be made, there is a discussion about it [here](https://forum.ionicframework.com/t/rc0-typescript-private-vs-public-keyword/64863/4?u=mhartington). -32. Change any Ionic buttons from `