javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-17 02:31:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(react): don't remove current view, provide a better method to determine showGoBack fixes #19731 and #19732

Browse Source
This commit is contained in:
Ely Lucas
2019-10-23 12:11:33 -06:00
parent d80f45516d
commit 29f8178794
2 changed files with 29 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/react-router/src/ReactRouter/RouteManagerContext.ts
View File

@ -1,4 +1,3 @@
import { NavDirection } from '@ionic/core';
import React, { ReactNode } from 'react';
import { ViewStacks } from './ViewStacks';
@ -9,7 +8,6 @@ export interface RouteManagerContextState {
viewStacks: ViewStacks;
setupIonRouter: (id: string, children: ReactNode, routerOutlet: HTMLIonRouterOutletElement) => Promise<void>;
removeViewStack: (stack: string) => void;
transitionView: (enteringEl: HTMLElement, leavingEl: HTMLElement, ionRouterOuter: HTMLIonRouterOutletElement, direction: NavDirection) => void;
}
export const RouteManagerContext = /*@__PURE__*/React.createContext<RouteManagerContextState>({
@ -17,8 +15,7 @@ export const RouteManagerContext = /*@__PURE__*/React.createContext<RouteManager
syncView: () => { navContextNotFoundError(); },
hideView: () => { navContextNotFoundError(); },
setupIonRouter: () => Promise.reject(navContextNotFoundError()),
removeViewStack: () => { navContextNotFoundError(); },
transitionView: () => { navContextNotFoundError(); }
removeViewStack: () => { navContextNotFoundError(); }
});
function navContextNotFoundError() {