javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-20 12:29:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(datetime): presentation time emits ionChange once (#24968)

Browse Source 
Resolves #24967
This commit is contained in:
Sean Perkins
2022-03-22 11:33:19 -04:00
committed by GitHub
parent a8fd2d9199
commit 2909b080b7
3 changed files with 72 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
core/src/components/picker-column-internal/picker-column-internal.tsx
View File

@ -67,16 +67,10 @@ export class PickerColumnInternal implements ComponentInterface {
valueChange() {
if (this.isColumnVisible) {
/**
* Only scroll the active item into view and emit the value
* change, when the picker column is actively visible to the user.
* Only scroll the active item into view when the picker column
* is actively visible to the user.
*/
const { items, value } = this;
this.scrollActiveItemIntoView();
const findItem = items.find(item => item.value === value);
if (findItem) {
this.ionChange.emit(findItem);
}
}
}
@ -133,7 +127,7 @@ export class PickerColumnInternal implements ComponentInterface {
* first item to match the scroll position of the column.
*
*/
this.value = items[0].value;
this.setValue(items[0].value);
}
}
}
@ -148,6 +142,15 @@ export class PickerColumnInternal implements ComponentInterface {
}
}
private setValue(value?: string | number) {
const { items } = this;
this.value = value;
const findItem = items.find(item => item.value === value);
if (findItem) {
this.ionChange.emit(findItem);
}
}
private centerPickerItemInView = (target: HTMLElement, smooth = true) => {
const { el, isColumnVisible } = this;
if (isColumnVisible) {
@ -250,7 +253,7 @@ export class PickerColumnInternal implements ComponentInterface {
const selectedItem = this.items[index];
if (selectedItem.value !== this.value) {
this.value = selectedItem.value;
this.setValue(selectedItem.value);
hapticSelectionEnd();
this.hapticsStarted = false;
}

24
core/src/components/picker-column-internal/test/basic/e2e.ts
View File

@ -51,6 +51,30 @@ describe('picker-column-internal', () => {
expect(activeColumn.innerText).toEqual('23');
});
it('should not emit ionChange when the value is modified externally', async () => {
const pickerColumn = await page.find('#default');
const ionChangeSpy = await pickerColumn.spyOnEvent('ionChange');
await page.$eval('#default', (el: any) => {
el.value = '12';
});
expect(ionChangeSpy).not.toHaveReceivedEvent();
});
it('should emit ionChange when the picker is scrolled', async () => {
const pickerColumn = await page.find('#default');
const ionChangeSpy = await pickerColumn.spyOnEvent('ionChange');
await page.$eval('#default', (el: any) => {
el.scrollTo(0, 300);
});
await ionChangeSpy.next();
expect(ionChangeSpy).toHaveReceivedEvent();
});
});
});