diff --git a/packages/core/src/components/select/test/basic/e2e.js b/packages/core/src/components/select/test/basic/e2e.js index 15e2a53b46..f516f6e612 100644 --- a/packages/core/src/components/select/test/basic/e2e.js +++ b/packages/core/src/components/select/test/basic/e2e.js @@ -8,13 +8,6 @@ class E2ETestPage extends Page { constructor(driver, platform) { super(driver, `http://localhost:3333/src/components/select/test/basic?ionicplatform=${platform}`); } - - present(buttonId) { - this.navigate(); - this.driver.findElement(By.id(buttonId)).click(); - this.driver.wait(until.elementLocated(By.css('.select-wrapper'))); - return this.driver.wait(until.elementIsVisible(this.driver.findElement(By.css('.select-wrapper')))); - } } platforms.forEach(platform => { @@ -23,5 +16,15 @@ platforms.forEach(platform => { const page = new E2ETestPage(driver, platform); return page.navigate(); }); + + register('should open gender single select', driver => { + const page = new E2ETestPage(driver, platform); + return page.present('#gender', { waitFor: '.alert-wrapper' }); + }); + + register('should open custom action sheet select', driver => { + const page = new E2ETestPage(driver, platform); + return page.present('#customSelect', { waitFor: '.action-sheet-wrapper' }); + }); }); }); diff --git a/packages/core/src/components/select/test/basic/index.html b/packages/core/src/components/select/test/basic/index.html index 06720b8173..5c260ef266 100644 --- a/packages/core/src/components/select/test/basic/index.html +++ b/packages/core/src/components/select/test/basic/index.html @@ -21,7 +21,7 @@ Gender - + Female Male @@ -29,7 +29,7 @@ Hair Color - + Brown Blonde Black diff --git a/packages/core/src/components/select/test/multiple-value/e2e.js b/packages/core/src/components/select/test/multiple-value/e2e.js index c9691715fb..e2287b9a64 100644 --- a/packages/core/src/components/select/test/multiple-value/e2e.js +++ b/packages/core/src/components/select/test/multiple-value/e2e.js @@ -8,13 +8,6 @@ class E2ETestPage extends Page { constructor(driver, platform) { super(driver, `http://localhost:3333/src/components/select/test/multiple-value?ionicplatform=${platform}`); } - - present(buttonId) { - this.navigate(); - this.driver.findElement(By.id(buttonId)).click(); - this.driver.wait(until.elementLocated(By.css('.select-wrapper'))); - return this.driver.wait(until.elementIsVisible(this.driver.findElement(By.css('.select-wrapper')))); - } } platforms.forEach(platform => { @@ -23,5 +16,10 @@ platforms.forEach(platform => { const page = new E2ETestPage(driver, platform); return page.navigate(); }); + + register('should open toppings multiple select', driver => { + const page = new E2ETestPage(driver, platform); + return page.present('#toppings', { waitFor: '.alert-wrapper'}); + }); }); }); diff --git a/packages/core/src/components/select/test/single-value/e2e.js b/packages/core/src/components/select/test/single-value/e2e.js index ad655ae674..026d5e3a9c 100644 --- a/packages/core/src/components/select/test/single-value/e2e.js +++ b/packages/core/src/components/select/test/single-value/e2e.js @@ -8,13 +8,6 @@ class E2ETestPage extends Page { constructor(driver, platform) { super(driver, `http://localhost:3333/src/components/select/test/single-value?ionicplatform=${platform}`); } - - present(buttonId) { - this.navigate(); - this.driver.findElement(By.id(buttonId)).click(); - this.driver.wait(until.elementLocated(By.css('.select-wrapper'))); - return this.driver.wait(until.elementIsVisible(this.driver.findElement(By.css('.select-wrapper')))); - } } platforms.forEach(platform => { @@ -23,5 +16,10 @@ platforms.forEach(platform => { const page = new E2ETestPage(driver, platform); return page.navigate(); }); + + register('should open gender single select', driver => { + const page = new E2ETestPage(driver, platform); + return page.present('#gender', { waitFor: '.alert-wrapper'}); + }); }); }); diff --git a/packages/core/src/components/select/test/single-value/index.html b/packages/core/src/components/select/test/single-value/index.html index ba1ae3bb58..cfb7da4e90 100644 --- a/packages/core/src/components/select/test/single-value/index.html +++ b/packages/core/src/components/select/test/single-value/index.html @@ -19,7 +19,7 @@ Gender - + Female Male diff --git a/packages/core/src/components/select/test/standalone/index.html b/packages/core/src/components/select/test/standalone/index.html index b1a019ecd2..0ee7e77733 100644 --- a/packages/core/src/components/select/test/standalone/index.html +++ b/packages/core/src/components/select/test/standalone/index.html @@ -9,19 +9,19 @@ - + Female Male - + Brown Blonde Black Red - + NES Nintendo64 PlayStation