refactor(loading): remove dismissOnPageChange

closes #14930
This commit is contained in:
Manu Mtz.-Almeida
2018-08-12 18:38:30 +02:00
parent d856ecfbbf
commit 270ece0b5e
4 changed files with 8 additions and 14 deletions

View File

@@ -36,6 +36,7 @@ A list of the breaking changes introduced to each component in Ionic Angular v4.
- [Item Sliding](#item-sliding)
- [Label](#label)
- [List Header](#list-header)
- [Loading](#loading)
- [Menu Toggle](#menu-toggle)
- [Modal](#modal)
- [Nav](#nav)
@@ -807,6 +808,13 @@ Previously an `ion-label` would automatically get added to an `ion-list-header`
</ion-list-header>
```
## Loading
`dismissOnPageChange` was removed. Fortunatelly all the navigation API is promise based and there are global events (`ionNavWillChange`) you can listen in order to detect when navigation occurs.
You should take advantage of these APIs in order to dismiss your loading overlay explicitally.
## Menu Toggle
### Markup Changed