From 22c0ea5bcdae0e1ac64c23496af475b76d6ac689 Mon Sep 17 00:00:00 2001 From: Manuel Mtz-Almeida Date: Wed, 20 Sep 2017 12:11:48 +0200 Subject: [PATCH] fix(reorder): support for slot="start" --- packages/core/src/components/list/list.tsx | 8 -------- packages/core/src/components/reorder/reorder-group.tsx | 5 +---- packages/core/src/components/reorder/reorder.scss | 2 +- packages/core/src/components/reorder/test/basic.html | 3 +-- 4 files changed, 3 insertions(+), 15 deletions(-) diff --git a/packages/core/src/components/list/list.tsx b/packages/core/src/components/list/list.tsx index 1de4a40c9e..46e6f52f3e 100644 --- a/packages/core/src/components/list/list.tsx +++ b/packages/core/src/components/list/list.tsx @@ -17,16 +17,8 @@ import { ItemSliding } from '../item-sliding/item-sliding'; export class List { @State() openContainer: ItemSliding; - @Prop() radioGroup: boolean; render() { - if (this.radioGroup) { - return ( - - - - ); - } return ; } diff --git a/packages/core/src/components/reorder/reorder-group.tsx b/packages/core/src/components/reorder/reorder-group.tsx index 3173892942..f97c689036 100644 --- a/packages/core/src/components/reorder/reorder-group.tsx +++ b/packages/core/src/components/reorder/reorder-group.tsx @@ -163,8 +163,6 @@ export class ReorderGroup { /** * @input {string} Which side of the view the ion-reorder should be placed. Default `"end"`. */ - @Prop() side: string; - @PropDidChange('enabled') enabledChanged(enabled: boolean) { if (enabled) { @@ -330,8 +328,7 @@ export class ReorderGroup { class: { 'reorder-enabled': this._enabled, 'reorder-list-active': this._actived, - 'reorder-visible': this._iconVisible, - 'reorder-side-start': this.side === 'start' + 'reorder-visible': this._iconVisible } }; } diff --git a/packages/core/src/components/reorder/reorder.scss b/packages/core/src/components/reorder/reorder.scss index d4144d3149..a16b01f215 100644 --- a/packages/core/src/components/reorder/reorder.scss +++ b/packages/core/src/components/reorder/reorder.scss @@ -52,7 +52,7 @@ ion-reorder ion-icon { pointer-events: none; } -.reorder-side-start ion-reorder { +ion-reorder[slot="start"] { @include transform(translate3d(-$reorder-initial-transform, 0, 0)); order: -1; diff --git a/packages/core/src/components/reorder/test/basic.html b/packages/core/src/components/reorder/test/basic.html index 527a7920a3..4d5aaf5178 100644 --- a/packages/core/src/components/reorder/test/basic.html +++ b/packages/core/src/components/reorder/test/basic.html @@ -30,8 +30,7 @@ Item 3 - - + Item 4