javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-16 18:17:31 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(react): overlays now define internal ionic components (#25967)

Browse Source 
resolves #25962
This commit is contained in:
Liam DeBeasi
2022-09-21 10:30:32 -05:00
committed by GitHub
parent 92264cd4b0
commit 21dc893f90
5 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/react/src/components/createControllerComponent.tsx
View File

@ -4,7 +4,6 @@ import React from 'react';
import {
attachProps,
dashToPascalCase,
defineCustomElement,
setRef,
} from './react-component-lib/utils';
@ -27,9 +26,11 @@ export const createControllerComponent = <
>(
tagName: string,
controller: { create: (options: OptionsType) => Promise<OverlayType> },
customElement?: any
defineCustomElement?: () => void
) => {
defineCustomElement(tagName, customElement);
if (defineCustomElement) {
defineCustomElement();
}
const displayName = dashToPascalCase(tagName);
const didDismissEventName = `on${displayName}DidDismiss`;