From 21d4af8cf9b2e0b5f849cbd329f89605e71f5a13 Mon Sep 17 00:00:00 2001 From: Adam Bradley Date: Sat, 15 Nov 2014 15:11:46 -0600 Subject: [PATCH] chore(navBarController): deprecate methods w/ warnings --- js/angular/controller/navBarController.js | 31 ++++++++++++++++++++++- js/angular/service/navBarDelegate.js | 10 +++++++- 2 files changed, 39 insertions(+), 2 deletions(-) diff --git a/js/angular/controller/navBarController.js b/js/angular/controller/navBarController.js index 65e3a1f319..374c369bce 100644 --- a/js/angular/controller/navBarController.js +++ b/js/angular/controller/navBarController.js @@ -8,7 +8,8 @@ IonicModule '$timeout', '$ionicNavBarDelegate', '$ionicConfig', -function($scope, $element, $attrs, $compile, $timeout, $ionicNavBarDelegate, $ionicConfig) { + '$ionicHistory', +function($scope, $element, $attrs, $compile, $timeout, $ionicNavBarDelegate, $ionicConfig, $ionicHistory) { var CSS_HIDE = 'hide'; var DATA_NAV_BAR_CTRL = '$ionNavBarController'; @@ -348,6 +349,34 @@ function($scope, $element, $attrs, $compile, $timeout, $ionicNavBarDelegate, $io }; + // DEPRECATED, as of v1.0.0-beta14 ------- + self.changeTitle = function(val) { + deprecatedWarning('changeTitle(val)', 'title(val)'); + self.title(val); + }; + self.setTitle = function(val) { + deprecatedWarning('setTitle(val)', 'title(val)'); + self.title(val); + }; + self.getTitle = function() { + deprecatedWarning('getTitle()', 'title()'); + return self.title(); + }; + self.back = function() { + deprecatedWarning('back()', '$ionicHistory.goBack()'); + $ionicHistory.goBack(); + }; + self.getPreviousTitle = function() { + deprecatedWarning('getPreviousTitle()', '$ionicHistory.backTitle()'); + $ionicHistory.goBack(); + }; + function deprecatedWarning(oldMethod, newMethod) { + var warn = console.warn || console.log; + warn && warn('navBarController.' + oldMethod + ' is deprecated, please use ' + newMethod + ' instead'); + } + // END DEPRECATED ------- + + function createNavElement(type) { if (navElementHtml[type]) { return jqLite(navElementHtml[type]); diff --git a/js/angular/service/navBarDelegate.js b/js/angular/service/navBarDelegate.js index 897f9de361..a342258889 100644 --- a/js/angular/service/navBarDelegate.js +++ b/js/angular/service/navBarDelegate.js @@ -70,5 +70,13 @@ IonicModule * supplied view data. * @param {object} viewData An object containing `title`, `showBar` properties. */ - 'update' + 'update', + + // DEPRECATED, as of v1.0.0-beta14 ------- + 'changeTitle', + 'setTitle', + 'getTitle', + 'back', + 'getPreviousTitle' + // END DEPRECATED ------- ]));