From 21c1b550efe910f94adbb428bb923bdf7945438b Mon Sep 17 00:00:00 2001 From: Adam Bradley Date: Fri, 19 Jun 2015 12:51:18 -0500 Subject: [PATCH] button fixes --- ionic/components/action-menu/action-menu.js | 6 +- ionic/components/alert/alert.js | 2 +- .../components/app/test/animations/main.html | 4 +- ionic/components/button/test/clear/main.html | 56 +++++------ ionic/components/button/test/full/main.html | 12 +-- ionic/components/button/test/icons/main.html | 36 +++---- .../components/button/test/outline/main.html | 48 ++++----- ionic/components/button/test/sizes/main.html | 28 +++--- ionic/components/modal/test/basic/index.js | 8 +- .../nav-bar/test/html-title/main.html | 4 +- .../nav-bar/test/long-title/main.html | 8 +- .../nav-bar/test/lopsided-buttons/main.html | 8 +- ionic/components/nav/test/basic/index.js | 8 +- .../nav/test/basic/pages/first-page.js | 99 ------------------- .../nav/test/basic/pages/second-page.js | 6 +- .../nav/test/basic/pages/third-page.js | 2 +- ionic/components/search-bar/search-bar.js | 2 +- .../test/settings/groups/general.js | 16 --- .../test/settings/groups/privacy.js | 74 -------------- .../split-view/test/settings/main.html | 2 - ionic/components/tabs/test/advanced/index.js | 18 ++-- 21 files changed, 128 insertions(+), 319 deletions(-) delete mode 100644 ionic/components/nav/test/basic/pages/first-page.js delete mode 100644 ionic/components/split-view/test/settings/groups/general.js delete mode 100644 ionic/components/split-view/test/settings/groups/privacy.js delete mode 100644 ionic/components/split-view/test/settings/main.html diff --git a/ionic/components/action-menu/action-menu.js b/ionic/components/action-menu/action-menu.js index 60b7d14748..2c40d0a481 100644 --- a/ionic/components/action-menu/action-menu.js +++ b/ionic/components/action-menu/action-menu.js @@ -27,11 +27,11 @@ import {ClickBlock} from '../../util/click-block';
{{options.titleText}}
- - + +
- +
`, diff --git a/ionic/components/alert/alert.js b/ionic/components/alert/alert.js index 12f2b7240b..6ff66f0a70 100644 --- a/ionic/components/alert/alert.js +++ b/ionic/components/alert/alert.js @@ -17,7 +17,7 @@ Seriously, who does not like cookies.
- +
` diff --git a/ionic/components/app/test/animations/main.html b/ionic/components/app/test/animations/main.html index 23522b223a..9d3a3f73c8 100644 --- a/ionic/components/app/test/animations/main.html +++ b/ionic/components/app/test/animations/main.html @@ -45,8 +45,8 @@

- - + +

diff --git a/ionic/components/button/test/clear/main.html b/ionic/components/button/test/clear/main.html index b225ada853..1279dbf1f8 100644 --- a/ionic/components/button/test/clear/main.html +++ b/ionic/components/button/test/clear/main.html @@ -1,49 +1,49 @@
- a (default) - - - + a[button][clear] + + +
- a.primary - - - + a.primary + + +
- a.secondary - - - + a.secondary + + +
- a.danger - - - + a.danger + + +
- a.light - - - + a.light + + +
- a.stable - - - + a.stable + + +
- a.dark - - - + a.dark + + +
diff --git a/ionic/components/button/test/full/main.html b/ionic/components/button/test/full/main.html index 8b51e516d3..2db73cae0b 100644 --- a/ionic/components/button/test/full/main.html +++ b/ionic/components/button/test/full/main.html @@ -1,15 +1,15 @@
- a.button-full - + a[button][full] +
- a.button-full - + a[button][full][outline] +
- a.button-full - + a[button][full][clear] +
diff --git a/ionic/components/button/test/icons/main.html b/ionic/components/button/test/icons/main.html index 7e0c35901c..1a73b0bd3d 100644 --- a/ionic/components/button/test/icons/main.html +++ b/ionic/components/button/test/icons/main.html @@ -2,77 +2,77 @@
- - + Left Icon
- - + Right Icon
- - +
- - + Left, Large
- - + Right, Large
- - +
- - + Left Icon, Small
- - + Right Icon, Small
- - +
diff --git a/ionic/components/button/test/outline/main.html b/ionic/components/button/test/outline/main.html index c48979b6a6..4bb8865ce0 100644 --- a/ionic/components/button/test/outline/main.html +++ b/ionic/components/button/test/outline/main.html @@ -1,42 +1,42 @@
- a.primary - - - + a.primary + + +
- a.secondary - - - + a.secondary + + +
- a.danger - - - + a.danger + + +
- a.light - - - + a.light + + +
- a.stable - - - + a.stable + + +
- a.dark - - - + a.dark + + +
diff --git a/ionic/components/button/test/sizes/main.html b/ionic/components/button/test/sizes/main.html index fc70874c3d..2051d9ea84 100644 --- a/ionic/components/button/test/sizes/main.html +++ b/ionic/components/button/test/sizes/main.html @@ -1,36 +1,36 @@
- a (default) - + a[button] +
- a.small - + a[small] + - a.outline.small - + a[outline][small] +
- a.clear.small - + a[clear][small] +
- + H E L L O - +
- a - + a + - a - + a +
diff --git a/ionic/components/modal/test/basic/index.js b/ionic/components/modal/test/basic/index.js index bcea6378b8..5fe3fdc7fb 100644 --- a/ionic/components/modal/test/basic/index.js +++ b/ionic/components/modal/test/basic/index.js @@ -37,14 +37,14 @@ export class ContactModal extends Modal { @Component({selector: 'ion-view'}) @View({ template: ` - First Page Header: {{ val }} + First Page Header: {{ val }}

First Page: {{ val }}

- +

@@ -85,11 +85,11 @@ export class ModalFirstPage {

- +

- +

diff --git a/ionic/components/nav-bar/test/html-title/main.html b/ionic/components/nav-bar/test/html-title/main.html index 1f3874348d..87f9edbec9 100644 --- a/ionic/components/nav-bar/test/html-title/main.html +++ b/ionic/components/nav-bar/test/html-title/main.html @@ -8,11 +8,11 @@ - + - + diff --git a/ionic/components/nav-bar/test/long-title/main.html b/ionic/components/nav-bar/test/long-title/main.html index 4ff15071f7..8aa9b7c4bc 100644 --- a/ionic/components/nav-bar/test/long-title/main.html +++ b/ionic/components/nav-bar/test/long-title/main.html @@ -2,13 +2,13 @@ - - - + + + - + diff --git a/ionic/components/nav-bar/test/lopsided-buttons/main.html b/ionic/components/nav-bar/test/lopsided-buttons/main.html index 7efc49ace6..4eb7e73c5f 100644 --- a/ionic/components/nav-bar/test/lopsided-buttons/main.html +++ b/ionic/components/nav-bar/test/lopsided-buttons/main.html @@ -2,13 +2,13 @@ - - - + + + - + diff --git a/ionic/components/nav/test/basic/index.js b/ionic/components/nav/test/basic/index.js index c10dc87e9f..efe28b8d62 100644 --- a/ionic/components/nav/test/basic/index.js +++ b/ionic/components/nav/test/basic/index.js @@ -15,17 +15,17 @@ import {SecondPage} from './pages/second-page' '' + 'First Page: {{ val }}' + '' + - '' + + '' + '' + '' + - '' + + '' + '' + '' + '' + '' + '

First Page: {{ val }}

' + - '

' + - '

' + + '

' + + '

' + '' + '' + '' + diff --git a/ionic/components/nav/test/basic/pages/first-page.js b/ionic/components/nav/test/basic/pages/first-page.js deleted file mode 100644 index 97541f7c35..0000000000 --- a/ionic/components/nav/test/basic/pages/first-page.js +++ /dev/null @@ -1,99 +0,0 @@ -import {Component, Directive, onInit} from 'angular2/src/core/annotations_impl/annotations'; -import {View} from 'angular2/src/core/annotations_impl/view'; - -import {Routable, Router, NavController, NavbarTemplate, Navbar, NavPush, Content} from 'ionic/ionic'; -import {IonicApp} from '../index'; -import {SecondPage} from './second-page'; - -@Component({ - selector: 'ion-view', - lifecycle: [onInit] -}) -@View({ - template: '' + - '' + - 'First Page: {{ val }}' + - '' + - '' + - '' + - '' + - '' + - '' + - '' + - '' + - '' + - '

First Page: {{ val }}

' + - '

' + - '

' + - '' + - '' + - '' + - '
', - directives: [NavbarTemplate, Navbar, NavPush, Content] -}) -export class FirstPage { - constructor( - nav: NavController - ) { - - // TODO: Shouldn't have to do this - Router.setNavController(nav); - - this.nav = nav; - this.val = Math.round(Math.random() * 8999) + 1000; - - - this.pushPage = SecondPage; - this.pushData = { - id: 420 - } - } - - onInit() { - } - - viewLoaded() { - this.router = FirstPage.router.invoke(this); - console.log('viewLoaded first page'); - } - - viewWillEnter() { - console.log('viewWillEnter first page'); - } - - viewDidEnter() { - console.log('viewDidEnter first page'); - } - - viewWillLeave() { - console.log('viewWillLeave first page'); - } - - viewDidLeave() { - console.log('viewDidLeave first page'); - } - - viewWillCache() { - console.log('viewWillCache first page'); - } - - viewDidCache() { - console.log('viewDidCache first page'); - } - - viewWillUnload() { - console.log('viewWillUnload first page'); - } - - viewDidUnload() { - console.log('viewDidUnload first page'); - } - - push() { - this.nav.push(SecondPage, { id: 8675309, myData: [1,2,3,4] }, { animation: 'ios' }); - } -} - -new Routable(FirstPage, { - url: '/first-page' -}) diff --git a/ionic/components/nav/test/basic/pages/second-page.js b/ionic/components/nav/test/basic/pages/second-page.js index 94ba640359..a1cdc4667c 100644 --- a/ionic/components/nav/test/basic/pages/second-page.js +++ b/ionic/components/nav/test/basic/pages/second-page.js @@ -11,13 +11,13 @@ import {ThirdPage} from './third-page'; Second Page Header

- +

- +

- +

Random: {{ val }} diff --git a/ionic/components/nav/test/basic/pages/third-page.js b/ionic/components/nav/test/basic/pages/third-page.js index 64c8fc7fc7..8f29cdb902 100644 --- a/ionic/components/nav/test/basic/pages/third-page.js +++ b/ionic/components/nav/test/basic/pages/third-page.js @@ -10,7 +10,7 @@ import {Router, Routable, NavController, NavbarTemplate, Navbar, Content} from ' Third Page Header

- +

diff --git a/ionic/components/search-bar/search-bar.js b/ionic/components/search-bar/search-bar.js index 69d1c37e7c..b98d6d5885 100644 --- a/ionic/components/search-bar/search-bar.js +++ b/ionic/components/search-bar/search-bar.js @@ -15,7 +15,7 @@ import {IonicComponent} from 'ionic/config/component'
- ` + ` }) export class SearchBar { diff --git a/ionic/components/split-view/test/settings/groups/general.js b/ionic/components/split-view/test/settings/groups/general.js deleted file mode 100644 index 5dbe1b2c00..0000000000 --- a/ionic/components/split-view/test/settings/groups/general.js +++ /dev/null @@ -1,16 +0,0 @@ -import {Component, View} from 'angular2/angular2' - - -@Component({ - selector: 'settings-general' -}) -@View({ - template: ` - - General Settings - - `, - directives: [] -}) -export class GeneralPage { -} diff --git a/ionic/components/split-view/test/settings/groups/privacy.js b/ionic/components/split-view/test/settings/groups/privacy.js deleted file mode 100644 index 8b068db786..0000000000 --- a/ionic/components/split-view/test/settings/groups/privacy.js +++ /dev/null @@ -1,74 +0,0 @@ -import {Component, View} from 'angular2/angular2' -import {NavPane} from 'ionic/ionic' - -@Component({ selector: 'privacy-settings' }) -@View({ - template: ` - - Privacy - -`, - directives: [] -}) -export class PrivacyPage { - constructor(navPane: NavPane) { - this.navPane = navPane - } - next() { - this.navPane.push(PrivacyP1) - } -} - -@Component({ selector: 'privp1' }) -@View({ - template: ` - -This is page 1 -
- -
- -
-`, - directives: [] -}) -class PrivacyP1 { - constructor(navPane: NavPane) { - this.navPane = navPane - } - next() { - this.navPane.push(PrivacyP2) - } - pop() { - this.navPane.pop() - } -} - -@Component({ selector: 'privp2' }) -@View({ - template: ` - -Page 2 here -
- -
-
-`, - directives: [] -}) -class PrivacyP2 { - constructor(navPane: NavPane) { - this.navPane = navPane - } - pop() { - this.navPane.pop() - } -} diff --git a/ionic/components/split-view/test/settings/main.html b/ionic/components/split-view/test/settings/main.html deleted file mode 100644 index a942ebb790..0000000000 --- a/ionic/components/split-view/test/settings/main.html +++ /dev/null @@ -1,2 +0,0 @@ - - diff --git a/ionic/components/tabs/test/advanced/index.js b/ionic/components/tabs/test/advanced/index.js index c89e82927e..90662e74f2 100644 --- a/ionic/components/tabs/test/advanced/index.js +++ b/ionic/components/tabs/test/advanced/index.js @@ -11,7 +11,7 @@ import {Tabs, Tab, NavController, NavbarTemplate, Navbar, Content} from 'ionic/i 'Sign In' + '' + '' + - '

' + + '

' + '' + '' + '
', @@ -54,7 +54,7 @@ class TabsPage { 'Tabs 1 Page 1' + '' + '' + - '

' + + '

' + '' + '' + '
', @@ -77,8 +77,8 @@ class Tab1Page1 { 'Tabs 1 Page 2' + '' + '' + - '

' + - '

' + + '

' + + '

' + '' + '' + '
', @@ -101,7 +101,7 @@ class Tab1Page2 { 'Tabs 1 Page 3' + '' + '' + - '

' + + '

' + '' + '' + '
', @@ -125,7 +125,7 @@ class Tab1Page3 { 'Tabs 2 Page 1' + '' + '' + - '

' + + '

' + '' + '' + '
', @@ -148,8 +148,8 @@ class Tab2Page1 { 'Tabs 2 Page 2' + '' + '' + - '

' + - '

' + + '

' + + '

' + '' + '' + '
', @@ -172,7 +172,7 @@ class Tab2Page2 { 'Tabs 2 Page 3' + '' + '' + - '

' + + '

' + '' + '' + '
',