javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-19 03:32:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(tap-click): instant activate does not use a setTimeout (#26748)

Browse Source
This commit is contained in:
Liam DeBeasi
2023-02-09 09:09:51 -05:00
committed by GitHub
parent c07933cb69
commit 21c0806bbd
2 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
core/src/utils/tap-click/index.ts
View File

@ -91,12 +91,17 @@ export const startTapClick = (config: Config) => {
clearDefers.delete(el); clearDefers.delete(el);
} }
const delay = isInstant(el) ? 0 : ADD_ACTIVATED_DEFERS;
el.classList.remove(ACTIVATED); el.classList.remove(ACTIVATED);
activeDefer = setTimeout(() => { const callback = () => {
addActivated(el, x, y); addActivated(el, x, y);
activeDefer = undefined; activeDefer = undefined;
}, delay); };
if (isInstant(el)) {
callback();
} else {
activeDefer = setTimeout(callback, ADD_ACTIVATED_DEFERS);
}
} }
activatableEle = el; activatableEle = el;
}; };

5
core/src/utils/tap-click/test/tap-click.e2e.ts
View File

@ -1,8 +1,7 @@
import { expect } from '@playwright/test'; import { expect } from '@playwright/test';
import { test } from '@utils/test/playwright'; import { test } from '@utils/test/playwright';
// TODO FW-3010 test.describe('tap click utility', () => {
test.describe.skip('tap click utility', () => {
test.beforeEach(({ skip }) => { test.beforeEach(({ skip }) => {
skip.rtl(); skip.rtl();
skip.mode('ios'); skip.mode('ios');
@ -10,7 +9,7 @@ test.describe.skip('tap click utility', () => {
test('it should apply activated class when clicking element', async ({ page }) => { test('it should apply activated class when clicking element', async ({ page }) => {
await page.setContent(` await page.setContent(`
<ion-app> <ion-app>
<button class="ion-activatable">Click Me</button> <button class="ion-activatable ion-activatable-instant">Click Me</button>
</ion-app> </ion-app>
`); `);