diff --git a/core/src/components/app/test/safe-area/app.e2e-legacy.ts b/core/src/components/app/test/safe-area/app.e2e-legacy.ts deleted file mode 100644 index d59391f278..0000000000 --- a/core/src/components/app/test/safe-area/app.e2e-legacy.ts +++ /dev/null @@ -1,34 +0,0 @@ -import { expect } from '@playwright/test'; -import { test } from '@utils/test/playwright'; -import type { E2EPage } from '@utils/test/playwright'; - -test.describe('app: safe-area', () => { - const testOverlay = async (page: E2EPage, trigger: string, event: string, screenshotModifier: string) => { - const presentEvent = await page.spyOnEvent(event); - - await page.click(trigger); - await presentEvent.next(); - - // Sometimes the inner content takes a frame or two to render - await page.waitForChanges(); - - await expect(page).toHaveScreenshot(`app-${screenshotModifier}-diff-${page.getSnapshotSettings()}.png`); - }; - test.beforeEach(async ({ page, skip }) => { - skip.rtl('Safe area tests only check top and bottom edges. RTL checks are not required here.'); - - await page.goto(`/src/components/app/test/safe-area`); - }); - test('should not have visual regressions with action sheet', async ({ page }) => { - await testOverlay(page, '#show-action-sheet', 'ionActionSheetDidPresent', 'action-sheet'); - }); - test('should not have visual regressions with menu', async ({ page }) => { - await testOverlay(page, '#show-menu', 'ionDidOpen', 'menu'); - }); - test('should not have visual regressions with picker', async ({ page }) => { - await testOverlay(page, '#show-picker', 'ionPickerDidPresent', 'picker'); - }); - test('should not have visual regressions with toast', async ({ page }) => { - await testOverlay(page, '#show-toast', 'ionToastDidPresent', 'toast'); - }); -}); diff --git a/core/src/components/app/test/safe-area/app.e2e.ts b/core/src/components/app/test/safe-area/app.e2e.ts new file mode 100644 index 0000000000..f2f5c8872e --- /dev/null +++ b/core/src/components/app/test/safe-area/app.e2e.ts @@ -0,0 +1,37 @@ +import { expect } from '@playwright/test'; +import { configs, test } from '@utils/test/playwright'; +import type { E2EPage } from '@utils/test/playwright'; + +/** + * Safe area tests only check top and bottom edges. RTL checks are not required here. + */ +configs({ directions: ['ltr'] }).forEach(({ config, title, screenshot }) => { + test.describe(title('app: safe-area'), () => { + const testOverlay = async (page: E2EPage, trigger: string, event: string, screenshotModifier: string) => { + const presentEvent = await page.spyOnEvent(event); + + await page.click(trigger); + await presentEvent.next(); + + // Sometimes the inner content takes a frame or two to render + await page.waitForChanges(); + + await expect(page).toHaveScreenshot(screenshot(`app-${screenshotModifier}-diff`)); + }; + test.beforeEach(async ({ page }) => { + await page.goto(`/src/components/app/test/safe-area`, config); + }); + test('should not have visual regressions with action sheet', async ({ page }) => { + await testOverlay(page, '#show-action-sheet', 'ionActionSheetDidPresent', 'action-sheet'); + }); + test('should not have visual regressions with menu', async ({ page }) => { + await testOverlay(page, '#show-menu', 'ionDidOpen', 'menu'); + }); + test('should not have visual regressions with picker', async ({ page }) => { + await testOverlay(page, '#show-picker', 'ionPickerDidPresent', 'picker'); + }); + test('should not have visual regressions with toast', async ({ page }) => { + await testOverlay(page, '#show-toast', 'ionToastDidPresent', 'toast'); + }); + }); +}); diff --git a/core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-action-sheet-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-action-sheet-diff-ios-ltr-Mobile-Chrome-linux.png similarity index 100% rename from core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-action-sheet-diff-ios-ltr-Mobile-Chrome-linux.png rename to core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-action-sheet-diff-ios-ltr-Mobile-Chrome-linux.png diff --git a/core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-action-sheet-diff-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-action-sheet-diff-ios-ltr-Mobile-Firefox-linux.png similarity index 100% rename from core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-action-sheet-diff-ios-ltr-Mobile-Firefox-linux.png rename to core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-action-sheet-diff-ios-ltr-Mobile-Firefox-linux.png diff --git a/core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-action-sheet-diff-ios-ltr-Mobile-Safari-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-action-sheet-diff-ios-ltr-Mobile-Safari-linux.png similarity index 100% rename from core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-action-sheet-diff-ios-ltr-Mobile-Safari-linux.png rename to core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-action-sheet-diff-ios-ltr-Mobile-Safari-linux.png diff --git a/core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-action-sheet-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-action-sheet-diff-md-ltr-Mobile-Chrome-linux.png similarity index 100% rename from core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-action-sheet-diff-md-ltr-Mobile-Chrome-linux.png rename to core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-action-sheet-diff-md-ltr-Mobile-Chrome-linux.png diff --git a/core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-action-sheet-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-action-sheet-diff-md-ltr-Mobile-Firefox-linux.png similarity index 100% rename from core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-action-sheet-diff-md-ltr-Mobile-Firefox-linux.png rename to core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-action-sheet-diff-md-ltr-Mobile-Firefox-linux.png diff --git a/core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-action-sheet-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-action-sheet-diff-md-ltr-Mobile-Safari-linux.png similarity index 100% rename from core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-action-sheet-diff-md-ltr-Mobile-Safari-linux.png rename to core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-action-sheet-diff-md-ltr-Mobile-Safari-linux.png diff --git a/core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-menu-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-menu-diff-ios-ltr-Mobile-Chrome-linux.png similarity index 100% rename from core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-menu-diff-ios-ltr-Mobile-Chrome-linux.png rename to core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-menu-diff-ios-ltr-Mobile-Chrome-linux.png diff --git a/core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-menu-diff-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-menu-diff-ios-ltr-Mobile-Firefox-linux.png similarity index 100% rename from core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-menu-diff-ios-ltr-Mobile-Firefox-linux.png rename to core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-menu-diff-ios-ltr-Mobile-Firefox-linux.png diff --git a/core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-menu-diff-ios-ltr-Mobile-Safari-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-menu-diff-ios-ltr-Mobile-Safari-linux.png similarity index 100% rename from core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-menu-diff-ios-ltr-Mobile-Safari-linux.png rename to core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-menu-diff-ios-ltr-Mobile-Safari-linux.png diff --git a/core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-menu-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-menu-diff-md-ltr-Mobile-Chrome-linux.png similarity index 100% rename from core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-menu-diff-md-ltr-Mobile-Chrome-linux.png rename to core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-menu-diff-md-ltr-Mobile-Chrome-linux.png diff --git a/core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-menu-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-menu-diff-md-ltr-Mobile-Firefox-linux.png similarity index 100% rename from core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-menu-diff-md-ltr-Mobile-Firefox-linux.png rename to core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-menu-diff-md-ltr-Mobile-Firefox-linux.png diff --git a/core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-menu-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-menu-diff-md-ltr-Mobile-Safari-linux.png similarity index 100% rename from core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-menu-diff-md-ltr-Mobile-Safari-linux.png rename to core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-menu-diff-md-ltr-Mobile-Safari-linux.png diff --git a/core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-picker-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-picker-diff-ios-ltr-Mobile-Chrome-linux.png similarity index 100% rename from core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-picker-diff-ios-ltr-Mobile-Chrome-linux.png rename to core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-picker-diff-ios-ltr-Mobile-Chrome-linux.png diff --git a/core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-picker-diff-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-picker-diff-ios-ltr-Mobile-Firefox-linux.png similarity index 100% rename from core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-picker-diff-ios-ltr-Mobile-Firefox-linux.png rename to core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-picker-diff-ios-ltr-Mobile-Firefox-linux.png diff --git a/core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-picker-diff-ios-ltr-Mobile-Safari-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-picker-diff-ios-ltr-Mobile-Safari-linux.png similarity index 100% rename from core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-picker-diff-ios-ltr-Mobile-Safari-linux.png rename to core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-picker-diff-ios-ltr-Mobile-Safari-linux.png diff --git a/core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-picker-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-picker-diff-md-ltr-Mobile-Chrome-linux.png similarity index 100% rename from core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-picker-diff-md-ltr-Mobile-Chrome-linux.png rename to core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-picker-diff-md-ltr-Mobile-Chrome-linux.png diff --git a/core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-picker-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-picker-diff-md-ltr-Mobile-Firefox-linux.png similarity index 100% rename from core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-picker-diff-md-ltr-Mobile-Firefox-linux.png rename to core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-picker-diff-md-ltr-Mobile-Firefox-linux.png diff --git a/core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-picker-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-picker-diff-md-ltr-Mobile-Safari-linux.png similarity index 100% rename from core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-picker-diff-md-ltr-Mobile-Safari-linux.png rename to core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-picker-diff-md-ltr-Mobile-Safari-linux.png diff --git a/core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-toast-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-toast-diff-ios-ltr-Mobile-Chrome-linux.png similarity index 100% rename from core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-toast-diff-ios-ltr-Mobile-Chrome-linux.png rename to core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-toast-diff-ios-ltr-Mobile-Chrome-linux.png diff --git a/core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-toast-diff-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-toast-diff-ios-ltr-Mobile-Firefox-linux.png similarity index 100% rename from core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-toast-diff-ios-ltr-Mobile-Firefox-linux.png rename to core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-toast-diff-ios-ltr-Mobile-Firefox-linux.png diff --git a/core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-toast-diff-ios-ltr-Mobile-Safari-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-toast-diff-ios-ltr-Mobile-Safari-linux.png similarity index 100% rename from core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-toast-diff-ios-ltr-Mobile-Safari-linux.png rename to core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-toast-diff-ios-ltr-Mobile-Safari-linux.png diff --git a/core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-toast-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-toast-diff-md-ltr-Mobile-Chrome-linux.png similarity index 100% rename from core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-toast-diff-md-ltr-Mobile-Chrome-linux.png rename to core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-toast-diff-md-ltr-Mobile-Chrome-linux.png diff --git a/core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-toast-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-toast-diff-md-ltr-Mobile-Firefox-linux.png similarity index 100% rename from core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-toast-diff-md-ltr-Mobile-Firefox-linux.png rename to core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-toast-diff-md-ltr-Mobile-Firefox-linux.png diff --git a/core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-toast-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-toast-diff-md-ltr-Mobile-Safari-linux.png similarity index 100% rename from core/src/components/app/test/safe-area/app.e2e-legacy.ts-snapshots/app-toast-diff-md-ltr-Mobile-Safari-linux.png rename to core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-toast-diff-md-ltr-Mobile-Safari-linux.png