diff --git a/core/src/components/accordion/test/a11y/accordion.e2e.ts b/core/src/components/accordion/test/a11y/accordion.e2e.ts index fce2bcc6c8..4abd5a7bf2 100644 --- a/core/src/components/accordion/test/a11y/accordion.e2e.ts +++ b/core/src/components/accordion/test/a11y/accordion.e2e.ts @@ -3,10 +3,11 @@ import { configs, test } from '@utils/test/playwright'; configs().forEach(({ config, title }) => { test.describe(title('accordion: a11y'), () => { - test('accordions should be keyboard navigable', async ({ page, skip, browserName }) => { - // TODO(FW-1764): remove skip once issue is resolved + // TODO(ROU-8157): remove skip once the keyboard navigation is working again + test.skip('accordions should be keyboard navigable', async ({ page, skip, browserName }) => { + // TODO(ROU-5358): remove skip once issue is resolved skip.browser('firefox', 'https://github.com/ionic-team/ionic-framework/issues/25070'); - // TODO (FW-2979) + // TODO (ROU-5437) skip.browser('webkit', 'Safari 16 only allows text fields and pop-up menus to be focused.'); await page.goto(`/src/components/accordion/test/a11y`, config); diff --git a/core/src/components/accordion/test/standalone/index.html b/core/src/components/accordion/test/standalone/index.html index 50cf965424..2cf504b7ec 100644 --- a/core/src/components/accordion/test/standalone/index.html +++ b/core/src/components/accordion/test/standalone/index.html @@ -2,7 +2,7 @@ - Accordion - Basic + Accordion - Standalone @@ -119,6 +119,7 @@ outline: none; text-align: left; padding: 20px 16px; + color: black; } .custom-accordion-content { diff --git a/core/src/components/alert/test/a11y/alert.e2e.ts-snapshots/alert-scale-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/alert/test/a11y/alert.e2e.ts-snapshots/alert-scale-ios-ltr-Mobile-Chrome-linux.png index d838af9af8..06ac65c3f3 100644 Binary files a/core/src/components/alert/test/a11y/alert.e2e.ts-snapshots/alert-scale-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/alert/test/a11y/alert.e2e.ts-snapshots/alert-scale-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e.ts b/core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e.ts index b5bd6a384f..088f3f98ec 100644 --- a/core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e.ts +++ b/core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e.ts @@ -11,7 +11,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ config, screenshot, t test('should update the active item', async ({ page }) => { const breadcrumbItems = page.locator('ion-breadcrumb'); - const addItemButton = page.locator('ion-button#add-btn'); + const addItemButton = page.locator('#add-btn'); await expect(breadcrumbItems).toHaveCount(4); diff --git a/core/src/components/datetime/test/position/datetime.e2e.ts b/core/src/components/datetime/test/position/datetime.e2e.ts index c817e3c6d0..f502252d7f 100644 --- a/core/src/components/datetime/test/position/datetime.e2e.ts +++ b/core/src/components/datetime/test/position/datetime.e2e.ts @@ -7,7 +7,7 @@ configs().forEach(({ title, screenshot, config }) => { await page.goto('/src/components/datetime/test/position', config); const ionPopoverDidPresent = await page.spyOnEvent('ionPopoverDidPresent'); - const openDateTimeBtn = page.locator('ion-button#open-datetime'); + const openDateTimeBtn = page.locator('#open-datetime'); await openDateTimeBtn.click(); await ionPopoverDidPresent.next(); diff --git a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-ltr-Mobile-Chrome-linux.png index 71dbd7531c..7c13325072 100644 Binary files a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-ltr-Mobile-Firefox-linux.png index c531b7258c..4fdf457d5e 100644 Binary files a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-ltr-Mobile-Firefox-linux.png and b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-ltr-Mobile-Safari-linux.png b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-ltr-Mobile-Safari-linux.png index 411e61cacb..df92abf3d7 100644 Binary files a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-rtl-Mobile-Chrome-linux.png index 6a0f0dd782..0d45b2f762 100644 Binary files a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-rtl-Mobile-Firefox-linux.png index c685c84300..9b774c1bac 100644 Binary files a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-rtl-Mobile-Firefox-linux.png and b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-rtl-Mobile-Safari-linux.png b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-rtl-Mobile-Safari-linux.png index 4f517a0c49..1c4647ca22 100644 Binary files a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-md-ltr-Mobile-Chrome-linux.png b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-md-ltr-Mobile-Chrome-linux.png index a7156daf4b..67a6806684 100644 Binary files a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-md-ltr-Mobile-Firefox-linux.png b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-md-ltr-Mobile-Firefox-linux.png index 70c7dbda84..abb071e7da 100644 Binary files a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-md-ltr-Mobile-Safari-linux.png b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-md-ltr-Mobile-Safari-linux.png index f52d59ffe2..d0515680cf 100644 Binary files a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-md-ltr-Mobile-Safari-linux.png and b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-md-rtl-Mobile-Chrome-linux.png b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-md-rtl-Mobile-Chrome-linux.png index f6d3c684c8..a4a60e207e 100644 Binary files a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-md-rtl-Mobile-Firefox-linux.png b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-md-rtl-Mobile-Firefox-linux.png index 781979268d..1256454e0d 100644 Binary files a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-md-rtl-Mobile-Firefox-linux.png and b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-md-rtl-Mobile-Safari-linux.png b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-md-rtl-Mobile-Safari-linux.png index 5fd6d98625..9ea5a32673 100644 Binary files a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-md-rtl-Mobile-Safari-linux.png and b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-base-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-ios-ltr-Mobile-Chrome-linux.png index 39040420ff..89b501bed7 100644 Binary files a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-ios-ltr-Mobile-Firefox-linux.png index e9ae2f9bac..874a208465 100644 Binary files a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-ios-ltr-Mobile-Firefox-linux.png and b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-ios-ltr-Mobile-Safari-linux.png b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-ios-ltr-Mobile-Safari-linux.png index e574efcaa4..485d1d7065 100644 Binary files a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-ios-rtl-Mobile-Chrome-linux.png index 8d24b95c17..3ba77e7731 100644 Binary files a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-ios-rtl-Mobile-Firefox-linux.png index 3ae4490d57..d9d62a9143 100644 Binary files a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-ios-rtl-Mobile-Firefox-linux.png and b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-ios-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-ios-rtl-Mobile-Safari-linux.png b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-ios-rtl-Mobile-Safari-linux.png index 691a32e9c3..c741abf779 100644 Binary files a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-md-ltr-Mobile-Chrome-linux.png b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-md-ltr-Mobile-Chrome-linux.png index 2cf4408518..83cdb864fc 100644 Binary files a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-md-ltr-Mobile-Firefox-linux.png b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-md-ltr-Mobile-Firefox-linux.png index eb3fab4f91..8378b1350f 100644 Binary files a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-md-ltr-Mobile-Safari-linux.png b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-md-ltr-Mobile-Safari-linux.png index 4f29ed53f2..0be057bcab 100644 Binary files a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-md-ltr-Mobile-Safari-linux.png and b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-md-rtl-Mobile-Chrome-linux.png b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-md-rtl-Mobile-Chrome-linux.png index 4895c84603..dfa1150a96 100644 Binary files a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-md-rtl-Mobile-Firefox-linux.png b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-md-rtl-Mobile-Firefox-linux.png index 7f34262810..494b51cffa 100644 Binary files a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-md-rtl-Mobile-Firefox-linux.png and b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-md-rtl-Mobile-Safari-linux.png b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-md-rtl-Mobile-Safari-linux.png index bdbb4ffc35..35260a6728 100644 Binary files a/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-md-rtl-Mobile-Safari-linux.png and b/core/src/components/datetime/test/position/datetime.e2e.ts-snapshots/datetime-position-popover-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts b/core/src/components/loading/test/basic/loading.e2e.ts index 002ab53b45..3f85cfacf1 100644 --- a/core/src/components/loading/test/basic/loading.e2e.ts +++ b/core/src/components/loading/test/basic/loading.e2e.ts @@ -74,7 +74,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, screenshot, c await ionLoadingDidPresent.next(); - const button = page.locator('ion-loading ion-button'); + const button = page.locator('ion-loading button'); if (browserName === 'webkit') { await page.keyboard.down('Alt'); diff --git a/core/src/components/menu/test/basic/menu.e2e.ts b/core/src/components/menu/test/basic/menu.e2e.ts index 23c3ad0c3c..4a9faeca61 100644 --- a/core/src/components/menu/test/basic/menu.e2e.ts +++ b/core/src/components/menu/test/basic/menu.e2e.ts @@ -29,7 +29,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => test('should trap focus', async ({ page, skip, browserName }) => { skip.browser('firefox', 'Firefox incorrectly allows keyboard focus to move to ion-content'); - // TODO (FW-2979) + // TODO (ROU-5437) skip.browser('webkit', 'Safari 16 only allows text fields and pop-up menus to be focused.'); const ionDidOpen = await page.spyOnEvent('ionDidOpen'); diff --git a/core/src/components/modal/test/trigger/modal.e2e.ts b/core/src/components/modal/test/trigger/modal.e2e.ts index 8513e2fbfb..4f2cc554d6 100644 --- a/core/src/components/modal/test/trigger/modal.e2e.ts +++ b/core/src/components/modal/test/trigger/modal.e2e.ts @@ -24,7 +24,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { await modal.evaluate((modal: HTMLIonModalElement) => { modal.remove(); - document.querySelector('ion-button')?.insertAdjacentElement('afterend', modal); + document.querySelector('button')?.insertAdjacentElement('afterend', modal); }); await page.waitForChanges(); diff --git a/core/src/components/nav/test/basic/nav.e2e.ts b/core/src/components/nav/test/basic/nav.e2e.ts index 6bef1d6c63..4cb898a0a2 100644 --- a/core/src/components/nav/test/basic/nav.e2e.ts +++ b/core/src/components/nav/test/basic/nav.e2e.ts @@ -18,7 +18,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => test.describe('pushing a new page', () => { test('should render the pushed component', async ({ page }) => { - const pageTwoButton = page.locator('ion-button:has-text("Go to Page Two")'); + const pageTwoButton = page.locator('button:has-text("Go to Page Two")'); const pageOne = page.locator('page-one'); const pageTwo = page.locator('page-two'); @@ -32,7 +32,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => }); test('should render the back button', async ({ page }) => { - const pageTwoButton = page.locator('ion-button:has-text("Go to Page Two")'); + const pageTwoButton = page.locator('button:has-text("Go to Page Two")'); const pageTwoBackButton = page.locator('page-two ion-back-button'); await pageTwoButton.click(); @@ -45,7 +45,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => test('back button should pop to the previous page', async ({ page }) => { const pageOne = page.locator('page-one'); const pageTwo = page.locator('page-two'); - const pageTwoButton = page.locator('ion-button:has-text("Go to Page Two")'); + const pageTwoButton = page.locator('button:has-text("Go to Page Two")'); const pageTwoBackButton = page.locator('page-two ion-back-button'); await pageTwoButton.click(); @@ -65,8 +65,8 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => const pageTwo = page.locator('page-two'); const pageThree = page.locator('page-three'); - const pageTwoButton = page.locator('ion-button:has-text("Go to Page Two")'); - const pageThreeButton = page.locator('ion-button:has-text("Go to Page Three")'); + const pageTwoButton = page.locator('button:has-text("Go to Page Two")'); + const pageThreeButton = page.locator('button:has-text("Go to Page Three")'); await pageTwoButton.click(); await page.waitForChanges(); diff --git a/core/src/components/nav/test/nested/nav.e2e.ts b/core/src/components/nav/test/nested/nav.e2e.ts index eb2ec32922..6ae571e5ff 100644 --- a/core/src/components/nav/test/nested/nav.e2e.ts +++ b/core/src/components/nav/test/nested/nav.e2e.ts @@ -16,8 +16,8 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => const pageOne = page.locator('page-one'); const pageTwo = page.locator('page-two'); - const pageTwoButton = page.locator('ion-button:has-text("Go to Page 2")'); - const pageTwoTwoButton = page.locator('ion-button:has-text("Go to Page 2.2")'); + const pageTwoButton = page.locator('button:has-text("Go to Page 2")'); + const pageTwoTwoButton = page.locator('button:has-text("Go to Page 2.2")'); await pageTwoButton.click(); await page.waitForChanges(); @@ -35,7 +35,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => await expect(pageTwoOne).toHaveCount(1); await expect(pageTwoTwo).toBeVisible(); - const pageThreeButton = page.locator('ion-button:has-text("Go to Page 3")'); + const pageThreeButton = page.locator('button:has-text("Go to Page 3")'); await pageThreeButton.click(); await page.waitForChanges(); @@ -49,8 +49,8 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => test.describe('back button', () => { test('should work with nested ion-nav', async ({ page }) => { - const pageTwoButton = page.locator('ion-button:has-text("Go to Page 2")'); - const pageTwoTwoButton = page.locator('ion-button:has-text("Go to Page 2.2")'); + const pageTwoButton = page.locator('button:has-text("Go to Page 2")'); + const pageTwoTwoButton = page.locator('button:has-text("Go to Page 2.2")'); await pageTwoButton.click(); await page.waitForChanges(); @@ -61,7 +61,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => await pageTwoTwoButton.click(); await page.waitForChanges(); - const pageThreeButton = page.locator('ion-button:has-text("Go to Page 3")'); + const pageThreeButton = page.locator('button:has-text("Go to Page 3")'); const pageThreeBackButton = page.locator('page-three ion-back-button'); await pageThreeButton.click(); diff --git a/core/src/components/nav/test/routing/nav.e2e.ts b/core/src/components/nav/test/routing/nav.e2e.ts index 33f02c9882..7d533d5213 100644 --- a/core/src/components/nav/test/routing/nav.e2e.ts +++ b/core/src/components/nav/test/routing/nav.e2e.ts @@ -24,8 +24,8 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => const pageOne = page.locator('page-one'); const pageTwo = page.locator('page-two'); - const pageOneButton = page.locator('ion-button:has-text("Go to Page One")'); - const pageTwoButton = page.locator('ion-button:has-text("Go to Page Two")'); + const pageOneButton = page.locator('button:has-text("Go to Page One")'); + const pageTwoButton = page.locator('button:has-text("Go to Page Two")'); await pageOneButton.click(); await page.waitForChanges(); @@ -45,7 +45,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => }); test('should render the back button', async ({ page }) => { - const pageOneButton = page.locator('ion-button:has-text("Go to Page One")'); + const pageOneButton = page.locator('button:has-text("Go to Page One")'); const pageOneBackButton = page.locator('page-one ion-back-button'); await pageOneButton.click(); @@ -59,7 +59,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => const pageRoot = page.locator('page-root'); const pageOne = page.locator('page-one'); - const pageOneButton = page.locator('ion-button:has-text("Go to Page One")'); + const pageOneButton = page.locator('button:has-text("Go to Page One")'); const pageOneBackButton = page.locator('page-one ion-back-button'); await pageOneButton.click(); @@ -80,9 +80,9 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => const pageTwo = page.locator('page-two'); const pageThree = page.locator('page-three'); - const pageOneButton = page.locator('ion-button:has-text("Go to Page One")'); - const pageTwoButton = page.locator('ion-button:has-text("Go to Page Two")'); - const pageThreeButton = page.locator('ion-button:has-text("Go to Page Three")'); + const pageOneButton = page.locator('button:has-text("Go to Page One")'); + const pageTwoButton = page.locator('button:has-text("Go to Page Two")'); + const pageThreeButton = page.locator('button:has-text("Go to Page Three")'); await pageOneButton.click(); await page.waitForChanges(); diff --git a/core/src/components/picker/test/basic/picker.e2e.ts b/core/src/components/picker/test/basic/picker.e2e.ts index 5c4a65caf7..0c51664a3e 100644 --- a/core/src/components/picker/test/basic/picker.e2e.ts +++ b/core/src/components/picker/test/basic/picker.e2e.ts @@ -105,7 +105,8 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => ); }); - test('tabbing should correctly move focus between columns', async ({ page }) => { + // TODO(FW-6232): remove this skip when tabbing is working properly + test.skip('tabbing should correctly move focus between columns', async ({ page }) => { const firstColumn = page.locator('ion-picker-column#first'); const secondColumn = page.locator('ion-picker-column#second'); @@ -120,7 +121,8 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => await expect(secondColumn).toBeFocused(); }); - test('tabbing should correctly move focus back', async ({ page }) => { + // TODO(FW-6232): remove this skip when tabbing is working properly + test.skip('tabbing should correctly move focus back', async ({ page }) => { const firstColumn = page.locator('ion-picker-column#first'); const secondColumn = page.locator('ion-picker-column#second'); diff --git a/core/src/components/picker/test/keyboard-entry/picker.e2e.ts b/core/src/components/picker/test/keyboard-entry/picker.e2e.ts index 64d4a1cce1..3aff0cc767 100644 --- a/core/src/components/picker/test/keyboard-entry/picker.e2e.ts +++ b/core/src/components/picker/test/keyboard-entry/picker.e2e.ts @@ -7,7 +7,8 @@ import type { E2ELocator } from '@utils/test/playwright/page/utils/locator'; */ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => { test.describe(title('picker: keyboard entry'), () => { - test('should scroll to and update the value prop for a single column', async ({ page }) => { + // TODO(FW-6232): remove this skip when keyboard entry is working properly + test.skip('should scroll to and update the value prop for a single column', async ({ page }) => { await page.setContent( ` @@ -122,7 +123,8 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => await expect(secondColumn).toHaveJSProperty('value', 24); }); - test('should select 00', async ({ page }) => { + // TODO(FW-6232): remove this skip when keyboard entry is working properly + test.skip('should select 00', async ({ page }) => { await page.setContent( ` diff --git a/core/src/components/popover/test/trigger/popover.e2e.ts b/core/src/components/popover/test/trigger/popover.e2e.ts index 23e43b2efb..9ba05adde6 100644 --- a/core/src/components/popover/test/trigger/popover.e2e.ts +++ b/core/src/components/popover/test/trigger/popover.e2e.ts @@ -40,7 +40,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { await popover.evaluate((popover: HTMLIonPopoverElement) => { popover.remove(); - document.querySelector('ion-button')?.insertAdjacentElement('afterend', popover); + document.querySelector('button')?.insertAdjacentElement('afterend', popover); }); await page.waitForChanges(); diff --git a/core/src/components/select-popover/test/basic/select-popover.e2e.ts b/core/src/components/select-popover/test/basic/select-popover.e2e.ts index f69e0240b9..14cc0c0c14 100644 --- a/core/src/components/select-popover/test/basic/select-popover.e2e.ts +++ b/core/src/components/select-popover/test/basic/select-popover.e2e.ts @@ -20,7 +20,7 @@ const checkedOptions: SelectPopoverOption[] = [ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { test.describe(title('select-popover: basic'), () => { test.beforeEach(({ browserName }) => { - test.skip(browserName === 'webkit', 'https://ionic-cloud.atlassian.net/browse/FW-2979'); + test.skip(browserName === 'webkit', 'ROU-5437'); }); test.describe('single selection', () => { @@ -55,7 +55,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { }); test('pressing Space on a selected option should dismiss the popover', async ({ browserName }) => { - test.skip(browserName === 'firefox', 'Same behavior as https://ionic-cloud.atlassian.net/browse/FW-2979'); + test.skip(browserName === 'firefox', 'Same behavior as ROU-5437'); await selectPopoverPage.setup(config, checkedOptions, false); diff --git a/core/src/components/select/test/basic/select.e2e.ts b/core/src/components/select/test/basic/select.e2e.ts index 44dd7dba25..4f9b666b58 100644 --- a/core/src/components/select/test/basic/select.e2e.ts +++ b/core/src/components/select/test/basic/select.e2e.ts @@ -40,7 +40,7 @@ configs({ directions: ['ltr'] }).forEach(({ title, config }) => { test.describe('select: popover', () => { test('it should open a popover select', async ({ page, skip }) => { - // TODO (FW-2979) + // TODO (ROU-5437) skip.browser('webkit', 'Safari 16 only allows text fields and pop-up menus to be focused.'); const ionPopoverDidPresent = await page.spyOnEvent('ionPopoverDidPresent'); diff --git a/core/src/components/select/test/disabled/select.e2e.ts b/core/src/components/select/test/disabled/select.e2e.ts index 9bc9389a3a..621ed048d3 100644 --- a/core/src/components/select/test/disabled/select.e2e.ts +++ b/core/src/components/select/test/disabled/select.e2e.ts @@ -4,7 +4,7 @@ import { configs, test } from '@utils/test/playwright'; configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => { test.describe(title('select: disabled options'), () => { test('should not focus a disabled option when no value is set', async ({ page, skip }) => { - // TODO (FW-2979) + // TODO (ROU-5437) skip.browser('webkit', 'Safari 16 only allows text fields and pop-up menus to be focused.'); test.info().annotations.push({