javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-22 13:32:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(all): make all method return a promise

Browse Source
This commit is contained in:
Manu Mtz.-Almeida
2018-08-28 18:16:10 +02:00
parent 5d32115684
commit 1d46973785
53 changed files with 307 additions and 442 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
core/src/components/picker/picker.tsx
View File

@ -1,4 +1,4 @@
import { Component, Element, Event, EventEmitter, Listen, Method, Prop, State } from '@stencil/core';
import { Component, Element, Event, EventEmitter, Listen, Method, Prop } from '@stencil/core';
import { Animation, AnimationBuilder, Config, CssClassMap, Mode, OverlayEventDetail, OverlayInterface, PickerButton, PickerColumn } from '../../interface';
import { dismiss, eventMethod, present } from '../../utils/overlays';
@ -23,9 +23,6 @@ export class Picker implements OverlayInterface {
@Element() el!: HTMLElement;
@State() private showSpinner!: boolean;
@State() private spinner!: string;
@Prop({ connect: 'ion-animation-controller' }) animationCtrl!: HTMLIonAnimationControllerElement;
@Prop({ context: 'config' }) config!: Config;
@ -113,16 +110,6 @@ export class Picker implements OverlayInterface {
*/
@Event() ionPickerDidUnload!: EventEmitter<void>;
componentWillLoad() {
if (!this.spinner) {
const defaultSpinner = this.mode === 'ios' ? 'lines' : 'crescent';
this.spinner = this.config.get('pickerSpinner', defaultSpinner);
}
if (this.showSpinner === undefined) {
this.showSpinner = !!(this.spinner && this.spinner !== 'hide');
}
}
componentDidLoad() {
this.ionPickerDidLoad.emit();
}
@ -183,10 +170,8 @@ export class Picker implements OverlayInterface {
*
*/
@Method()
onDidDismiss(
callback?: (detail: OverlayEventDetail) => void
): Promise<OverlayEventDetail> {
return eventMethod(this.el, 'ionPickerDidDismiss', callback);
onDidDismiss(): Promise<OverlayEventDetail> {
return eventMethod(this.el, 'ionPickerDidDismiss');
}
/**
@ -195,18 +180,16 @@ export class Picker implements OverlayInterface {
*
*/
@Method()
onWillDismiss(
callback?: (detail: OverlayEventDetail) => void
): Promise<OverlayEventDetail> {
return eventMethod(this.el, 'ionPickerWillDismiss', callback);
onWillDismiss(): Promise<OverlayEventDetail> {
return eventMethod(this.el, 'ionPickerWillDismiss');
}
/**
* Returns the column the matches the specified name
*/
@Method()
getColumn(name: string): PickerColumn | undefined {
return this.columns.find(column => column.name === name);
getColumn(name: string): Promise<PickerColumn | undefined> {
return Promise.resolve(this.columns.find(column => column.name === name));
}
private buttonClick(button: PickerButton) {