javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-20 12:29:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat(back-button): add 'backButtonDefaultHref' property to Ionic Config (#20491)

Browse Source 
closes #19305

Co-authored-by: Brandy Carney <brandy@ionic.io>
This commit is contained in:
EinfachHans
2020-04-27 16:57:43 +02:00
committed by GitHub
parent 32ecdd6753
commit 1b11ff7fb9
5 changed files with 55 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
core/src/components/back-button/back-button.tsx
View File

@ -31,7 +31,7 @@ export class BackButton implements ComponentInterface, ButtonInterface {
/**
* The url to navigate back to by default when there is no history.
*/
@Prop() defaultHref?: string;
@Prop({ mutable: true }) defaultHref?: string;
/**
* If `true`, the user cannot interact with the button.
@ -53,6 +53,12 @@ export class BackButton implements ComponentInterface, ButtonInterface {
*/
@Prop() type: 'submit' | 'reset' | 'button' = 'button';
componentWillLoad() {
if (this.defaultHref === undefined) {
this.defaultHref = config.get('backButtonDefaultHref');
}
}
get backButtonIcon() {
const icon = this.icon;
if (icon != null) {

33
core/src/components/back-button/test/back-button.spec.ts
View File

@ -70,4 +70,37 @@ describe('back button', () => {
});
describe('backButtonDefaultHref', () => {
it('set custom defaultHref in the config', async () => {
config.reset({
backButtonDefaultHref: 'custom-default-href-config'
});
const bb = await newBackButton();
expect(bb.defaultHref).toBe('custom-default-href-config');
});
it('set custom defaultHref on the instance', async () => {
const bb = await newBackButton();
bb.defaultHref = 'custom-default-href';
expect(bb.defaultHref).toBe('custom-default-href');
});
it('set custom defaultHref on the instance, override config', async () => {
const bb = await newBackButton();
bb.defaultHref = 'custom-default-href';
config.reset({
backButtonDefaultHref: 'custom-default-href-config'
});
expect(bb.defaultHref).toBe('custom-default-href');
const bb2 = await newBackButton();
bb2.defaultHref = 'custom-default-href-second';
expect(bb2.defaultHref).toBe('custom-default-href-second');
});
});
});