From 19f3bb23fd5587848fc41a744ca46ef5985c04d2 Mon Sep 17 00:00:00 2001 From: hoi4 Date: Mon, 11 Sep 2023 14:53:56 +0200 Subject: [PATCH] feat: export TransitionOptions interface and getIonPageElement (#28140) Issue number: resolves #28137 --------- Changes according to [this comment](https://github.com/ionic-team/ionic-framework/issues/28137#issuecomment-1710283096) ## Does this introduce a breaking change? - [ ] Yes - [x] No @liamdebeasi Sorry for replacing the previous PR. I only copied the main branch to my fork so I couldn't rebase properly. I am unfortunately not extremely familiar with Github. --------- Co-authored-by: Philipp Heuer Co-authored-by: Liam DeBeasi --- core/src/index.ts | 1 + core/src/interface.d.ts | 1 + packages/angular/src/index.ts | 2 ++ packages/react/src/components/index.ts | 2 ++ packages/vue/src/index.ts | 2 ++ 5 files changed, 8 insertions(+) diff --git a/core/src/index.ts b/core/src/index.ts index 6944306433..6bf73d5961 100644 --- a/core/src/index.ts +++ b/core/src/index.ts @@ -1,6 +1,7 @@ import 'ionicons'; export { createAnimation } from './utils/animation/animation'; +export { getIonPageElement } from './utils/transition'; export { iosTransitionAnimation } from './utils/transition/ios.transition'; export { mdTransitionAnimation } from './utils/transition/md.transition'; export { getTimeGivenProgression } from './utils/animation/cubic-bezier'; diff --git a/core/src/interface.d.ts b/core/src/interface.d.ts index b7bd05415e..377af9398a 100644 --- a/core/src/interface.d.ts +++ b/core/src/interface.d.ts @@ -43,6 +43,7 @@ export { AnimationKeyFrames, AnimationLifecycle, } from './utils/animation/animation-interface'; +export { TransitionOptions } from './utils/transition'; export { HTMLIonOverlayElement, OverlayController, OverlayInterface } from './utils/overlays-interface'; export { Config, config } from './global/config'; export { Gesture, GestureConfig, GestureDetail } from './utils/gesture'; diff --git a/packages/angular/src/index.ts b/packages/angular/src/index.ts index fb0daa2a4d..366ccf3742 100644 --- a/packages/angular/src/index.ts +++ b/packages/angular/src/index.ts @@ -55,6 +55,7 @@ export { getPlatforms, isPlatform, getTimeGivenProgression, + getIonPageElement, // TYPES Animation, AnimationBuilder, @@ -129,4 +130,5 @@ export { ToastLayout, ToggleChangeEventDetail, ToggleCustomEvent, + TransitionOptions, } from '@ionic/core'; diff --git a/packages/react/src/components/index.ts b/packages/react/src/components/index.ts index bb295f09a3..bfe29ae659 100644 --- a/packages/react/src/components/index.ts +++ b/packages/react/src/components/index.ts @@ -9,6 +9,7 @@ export { mdTransitionAnimation, IonicSlides, getTimeGivenProgression, + getIonPageElement, // TYPES Animation, @@ -83,6 +84,7 @@ export { ToastLayout, ToggleChangeEventDetail, ToggleCustomEvent, + TransitionOptions, } from '@ionic/core/components'; export * from './proxies'; diff --git a/packages/vue/src/index.ts b/packages/vue/src/index.ts index 158a2c9ffe..99822141c5 100644 --- a/packages/vue/src/index.ts +++ b/packages/vue/src/index.ts @@ -47,6 +47,7 @@ export { isPlatform, menuController, getTimeGivenProgression, + getIonPageElement, // TYPES Animation, @@ -123,4 +124,5 @@ export { ToastLayout, ToggleChangeEventDetail, ToggleCustomEvent, + TransitionOptions, } from "@ionic/core/components";