javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-17 18:54:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(segment): don't trigger scroll listener on segment button click

Browse Source
This commit is contained in:
Tanner Reits
2024-09-28 20:29:03 -04:00
parent 0fa5c99d99
commit 16c728b040
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
core/src/components/segment/segment.tsx
View File

@ -29,6 +29,7 @@ export class Segment implements ComponentInterface {
private segmentViewEl?: HTMLIonSegmentViewElement | null = null; private segmentViewEl?: HTMLIonSegmentViewElement | null = null;
private scrolledIndicator?: HTMLDivElement | null = null; private scrolledIndicator?: HTMLDivElement | null = null;
private isScrolling = false;
@Element() el!: HTMLIonSegmentElement; @Element() el!: HTMLIonSegmentElement;
@ -352,6 +353,10 @@ export class Segment implements ComponentInterface {
@Listen('ionSegmentViewScroll', { target: 'body' }) @Listen('ionSegmentViewScroll', { target: 'body' })
handleSegmentViewScroll(ev: CustomEvent) { handleSegmentViewScroll(ev: CustomEvent) {
if (!this.isScrolling) {
return;
}
const dispatchedFrom = ev.target as HTMLElement; const dispatchedFrom = ev.target as HTMLElement;
const segmentViewEl = this.segmentViewEl as EventTarget; const segmentViewEl = this.segmentViewEl as EventTarget;
const segmentEl = this.el; const segmentEl = this.el;
@ -401,7 +406,9 @@ export class Segment implements ComponentInterface {
} }
@Listen('ionSegmentViewScrollStart', { target: 'body' }) @Listen('ionSegmentViewScrollStart', { target: 'body' })
onScrollStart() {} onScrollStart() {
this.isScrolling = true;
}
@Listen('ionSegmentViewScrollEnd', { target: 'body' }) @Listen('ionSegmentViewScrollEnd', { target: 'body' })
onScrollEnd(ev: CustomEvent<{ activeContentId: string }>) { onScrollEnd(ev: CustomEvent<{ activeContentId: string }>) {
@ -411,6 +418,8 @@ export class Segment implements ComponentInterface {
this.scrolledIndicator.style.transition = ''; this.scrolledIndicator.style.transition = '';
this.scrolledIndicator.style.transform = ''; this.scrolledIndicator.style.transform = '';
} }
this.isScrolling = false;
} }
/** /**