From 16a283efe7232293018e0e874b4cdd4f25e1fd81 Mon Sep 17 00:00:00 2001 From: Adam Bradley Date: Tue, 12 Apr 2016 07:46:47 -0500 Subject: [PATCH] fix(virtualScroll): load async data Closes #6124 --- ionic/components/virtual-scroll/test/basic/index.ts | 3 +-- ionic/components/virtual-scroll/virtual-scroll.ts | 5 ++--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/ionic/components/virtual-scroll/test/basic/index.ts b/ionic/components/virtual-scroll/test/basic/index.ts index 0156b7aefd..e93d85c28d 100644 --- a/ionic/components/virtual-scroll/test/basic/index.ts +++ b/ionic/components/virtual-scroll/test/basic/index.ts @@ -11,10 +11,9 @@ class E2EPage { @ViewChild('content') content: ElementRef; constructor() { - for (var i = 0; i < 14; i++) { + for (var i = 0; i < 200; i++) { this.items.push(i); } - } headerFn(record: any, index: number, records: any[]) { diff --git a/ionic/components/virtual-scroll/virtual-scroll.ts b/ionic/components/virtual-scroll/virtual-scroll.ts index a9d51aaffe..80e64d0a02 100644 --- a/ionic/components/virtual-scroll/virtual-scroll.ts +++ b/ionic/components/virtual-scroll/virtual-scroll.ts @@ -334,6 +334,8 @@ export class VirtualScroll implements DoCheck, AfterContentInit, OnDestroy { throw 'virtualItem required within virtualScroll'; } + this._init = true; + this.update(true); this._platform.onResize(() => { @@ -398,9 +400,6 @@ export class VirtualScroll implements DoCheck, AfterContentInit, OnDestroy { // ******** DOM READ **************** readDimensions(function() { - // we were able to read good DOM dimension data, let's do this! - self._init = true; - processRecords(self._data.renderHeight, self._records, self._cells,