mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2025-11-07 15:07:13 +08:00
test(popover): skip flaky screenshot test (#27115)
<!-- Please refer to our contributing documentation for any questions on submitting a pull request, or let us know here if you need any help: https://ionicframework.com/docs/building/contributing --> <!-- Some docs updates need to be made in the `ionic-docs` repo, in a separate PR. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation for details. --> <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> <!-- Issues are required for both bug fixes and features. --> Popover test is still flaky: https://github.com/ionic-team/ionic-framework/actions/runs/4611219177/jobs/8150680142 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Re-open tech debt ticket and skip test ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
This commit is contained in:
@ -9,7 +9,8 @@ test.describe('popover: size', async () => {
|
|||||||
* and massively cut down on screenshots taken. The content has its own
|
* and massively cut down on screenshots taken. The content has its own
|
||||||
* backdrop so you can still see the popovers.
|
* backdrop so you can still see the popovers.
|
||||||
*/
|
*/
|
||||||
test('should calculate popover width based on sizing method', async ({ page }) => {
|
// TODO FW-3598
|
||||||
|
test.skip('should calculate popover width based on sizing method', async ({ page }) => {
|
||||||
await page.goto('/src/components/popover/test/size');
|
await page.goto('/src/components/popover/test/size');
|
||||||
await page.setViewportSize(Viewports.tablet.portrait); // avoid popovers overlapping
|
await page.setViewportSize(Viewports.tablet.portrait); // avoid popovers overlapping
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user