From 15b2b8022ce3837471513848a43f6784f3e3c366 Mon Sep 17 00:00:00 2001 From: Andrew Date: Fri, 20 Mar 2015 20:02:00 -0600 Subject: [PATCH] style(): add TODO about hardcoding things --- src/config.js | 3 +++ src/config_spec.js | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/config.js b/src/config.js index 565c682ea3..c27bb46b27 100644 --- a/src/config.js +++ b/src/config.js @@ -1,6 +1,8 @@ import * as Platform from './platform'; import * as util from './util'; +// TODO stop hardcoding platforms and media sizes + /* config .set({ side: 'left' }) @@ -83,6 +85,7 @@ class ConfigCase { } unset(key) { delete this._values[key]; + return this; } get(key) { return util.isDefined(this._values[key]) ? diff --git a/src/config_spec.js b/src/config_spec.js index 6a7c3baf20..59c6f000c6 100644 --- a/src/config_spec.js +++ b/src/config_spec.js @@ -75,7 +75,7 @@ export function main() { var sub1 = rootConfig.platform('ios'); sub1.set({ letter: 'b' }); expect(sub1.get('letter')).toBe('b'); - sub1.unset('letter'); + expect( sub1.unset('letter') ).toBe(sub1); expect(sub1.get('letter')).toBe('a'); });