javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-22 05:21:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(virtualScroll): fixes from rc1 breaking changes

Browse Source
This commit is contained in:
Adam Bradley
2016-05-13 22:58:50 -05:00
parent 4c19d15ee2
commit 158f7175d9
6 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ionic/components/virtual-scroll/test/basic/main.html
View File

@ -13,11 +13,11 @@
<ion-list [virtualScroll]="items" <ion-list [virtualScroll]="items"
[headerFn]="headerFn"> [headerFn]="headerFn">
<ion-item-divider *virtualHeader="#header"> <ion-item-divider *virtualHeader="let header">
Header: {{header}} Header: {{header}}
</ion-item-divider> </ion-item-divider>
<ion-item *virtualItem="#item"> <ion-item *virtualItem="let item">
Item: {{item}} Item: {{item}}
</ion-item> </ion-item>

2
ionic/components/virtual-scroll/test/cards/main.html
View File

@ -4,7 +4,7 @@
<div [virtualScroll]="items" approxItemHeight="320px"> <div [virtualScroll]="items" approxItemHeight="320px">
<ion-card *virtualItem="#item"> <ion-card *virtualItem="let item">
<div> <div>
<ion-img [src]="item.imgSrc" [height]="item.imgHeight"></ion-img> <ion-img [src]="item.imgSrc" [height]="item.imgHeight"></ion-img>

6
ionic/components/virtual-scroll/test/image-gallery/main.html
View File

@ -52,16 +52,16 @@
approxHeaderWidth="100%" approxHeaderWidth="100%"
approxHeaderHeight="36px"> approxHeaderHeight="36px">
<div *virtualHeader="#header" class="virtual-header"> <div *virtualHeader="let header" class="virtual-header">
Header: {{header.date}} Header: {{header.date}}
</div> </div>
<div *virtualItem="#item" class="virtual-item"> <div *virtualItem="let item" class="virtual-item">
<ion-img [src]="item.imgSrc"></ion-img> <ion-img [src]="item.imgSrc"></ion-img>
<!--{{ item.index }}--> <!--{{ item.index }}-->
</div> </div>
<div *virtualFooter="#footer" class="virtual-footer"> <div *virtualFooter="let footer" class="virtual-footer">
footer footer
</div> </div>

4
ionic/components/virtual-scroll/test/variable-size/main.html
View File

@ -4,11 +4,11 @@
<ion-list [virtualScroll]="items" [headerFn]="headerFn"> <ion-list [virtualScroll]="items" [headerFn]="headerFn">
<ion-item-divider *virtualHeader="#header"> <ion-item-divider *virtualHeader="let header">
Header: {{ header }} Header: {{ header }}
</ion-item-divider> </ion-item-divider>
<ion-item *virtualItem="#item"> <ion-item *virtualItem="let item">
<span [style.fontSize]="item.fontSize">{{ item.item }}</span> <span [style.fontSize]="item.fontSize">{{ item.item }}</span>
</ion-item> </ion-item>

2
ionic/components/virtual-scroll/virtual-scroll.ts
View File

@ -485,7 +485,7 @@ export class VirtualScroll implements DoCheck, AfterContentInit, OnDestroy {
for (var i = 0; i < this._nodes.length; i++) { for (var i = 0; i < this._nodes.length; i++) {
node = this._nodes[i]; node = this._nodes[i];
if (node.hasChanges) { if (node.hasChanges) {
node.view['changeDetectorRef'].detectChanges(); node.view['detectChanges']();
node.hasChanges = false; node.hasChanges = false;
} }
} }

2
ionic/components/virtual-scroll/virtual-util.ts
View File

@ -239,8 +239,6 @@ export function populateNodeData(startCellIndex: number, endCellIndex: number, v
// apply the cell's data to this node // apply the cell's data to this node
availableNode.view.context.$implicit = cell.data || records[cell.record]; availableNode.view.context.$implicit = cell.data || records[cell.record];
availableNode.view.context.index = cellIndex; availableNode.view.context.index = cellIndex;
availableNode.view.context.even = (cellIndex % 2 === 0);
availableNode.view.context.odd = (cellIndex % 2 === 1);
availableNode.hasChanges = true; availableNode.hasChanges = true;
availableNode.lastTransform = null; availableNode.lastTransform = null;
madeChanges = true; madeChanges = true;