From 1567dddde9b7cd15a29c14b990085111a85d59b1 Mon Sep 17 00:00:00 2001 From: Dan Bucholtz Date: Sat, 2 Dec 2017 00:45:37 -0600 Subject: [PATCH] refactor(loading): keep instance private --- packages/core/src/components/loading/loading.tsx | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/packages/core/src/components/loading/loading.tsx b/packages/core/src/components/loading/loading.tsx index a426ff105c..3b1532b46a 100644 --- a/packages/core/src/components/loading/loading.tsx +++ b/packages/core/src/components/loading/loading.tsx @@ -128,12 +128,11 @@ export class Loading { this.animation = null; } - this.ionLoadingWillPresent.emit({ loading: this }); + this.ionLoadingWillPresent.emit(); // get the user's animation fn if one was provided const animationBuilder = this.enterAnimation || this.config.get('loadingEnter', this.mode === 'ios' ? iosEnterAnimation : mdEnterAnimation); - // build the animation and kick it off // build the animation and kick it off return this.animationCtrl.create(animationBuilder, this.el).then(animation => { this.animation = animation; @@ -198,7 +197,7 @@ export class Loading { if (this.showSpinner === null || this.showSpinner === undefined) { this.showSpinner = !!(this.spinner && this.spinner !== 'hide'); } - this.ionLoadingDidLoad.emit({ loading: this }); + this.ionLoadingDidLoad.emit(); } componentDidEnter() { @@ -211,11 +210,11 @@ export class Loading { this.durationTimeout = setTimeout(() => this.dismiss(), this.duration); } - this.ionLoadingDidPresent.emit({ loading: this }); + this.ionLoadingDidPresent.emit(); } componentDidUnload() { - this.ionLoadingDidUnload.emit({ loading: this }); + this.ionLoadingDidUnload.emit(); } @Listen('ionDismiss')