javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-09 16:16:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(item-option): add styling for slots other than icon-only (#17711)

Browse Source 
styles the item option properly when icons are slotted. This was not working before at all for `top` and `bottom` slots.

- removes the e2e test from item/sliding in favor of all of them being under item-sliding
- adds more usage examples for all frameworks
- updates the styling for an anchor option so that it displays properly
- updates the standalone e2e test to take screenshots of the start icon, top icon, and anchor options
- updates the interactive e2e test to work locally
- cleaned up the CSS for start/end icons
- verified the styles for ben approval 💪

closes #17737 fixes #17402
This commit is contained in:
Brandy Carney
2019-03-15 13:46:57 -04:00
committed by GitHub
parent 29dbd0770c
commit 14f758ca97
22 changed files with 1332 additions and 535 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
core/src/components/loading/test/test.utils.ts
View File

@ -18,7 +18,7 @@ export async function testLoading(
url: pageUrl
});
const screenShotCompares = [];
const screenshotCompares = [];
await page.click(selector);
await page.waitForSelector(selector);
@ -28,18 +28,18 @@ export async function testLoading(
await loading.waitForVisible();
screenShotCompares.push(await page.compareScreenshot(screenshotName));
screenshotCompares.push(await page.compareScreenshot(screenshotName));
await loading.callMethod('dismiss');
await loading.waitForNotVisible();
screenShotCompares.push(await page.compareScreenshot(`dismiss ${screenshotName}`));
screenshotCompares.push(await page.compareScreenshot(`dismiss ${screenshotName}`));
loading = await page.find('ion-loading');
expect(loading).toBeNull();
for (const screenShotCompare of screenShotCompares) {
expect(screenShotCompare).toMatchScreenshot();
for (const screenshotCompare of screenshotCompares) {
expect(screenshotCompare).toMatchScreenshot();
}
} catch (err) {