javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-16 18:17:31 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(react, vue): remove sideeffects to improve treeshaking (#24313)

Browse Source
This commit is contained in:
Liam DeBeasi
2021-12-06 11:39:23 -05:00
committed by GitHub
parent 0920797612
commit 13d4418588
10 changed files with 455 additions and 355 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/react/src/components/react-component-lib/createComponent.tsx
View File

@ -4,7 +4,6 @@ import {
attachProps,
createForwardRef,
dashToPascalCase,
defineCustomElement,
isCoveredByReact,
mergeRefs,
} from './utils';
@ -30,9 +29,11 @@ export const createReactComponent = <
originalProps: StencilReactInternalProps<ElementType>,
propsToPass: any,
) => ExpandedPropsTypes,
customElement?: any,
defineCustomElement?: () => void,
) => {
defineCustomElement(tagName, customElement);
if (defineCustomElement !== undefined) {
defineCustomElement();
}
const displayName = dashToPascalCase(tagName);
const ReactComponent = class extends React.Component<StencilReactInternalProps<ElementType>> {