javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-08 23:58:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge remote-tracking branch 'origin/main' into sp/sync-feature-7-6-with-main

Browse Source
This commit is contained in:
Sean Perkins
2023-11-02 13:14:57 -04:00
parent 0854a11a25 ed040b09e9
commit 11fd074972
442 changed files with 2741 additions and 1435 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
core/src/components/radio/radio.ios.vars.scss
View File

@ -4,9 +4,6 @@
// iOS Radio
// --------------------------------------------------
/// @prop - Color of the checked radio
$radio-ios-color-on: current-color(base) !default;
/// @prop - Background color of focus indicator for radio when focused
$radio-ios-background-color-focused: ion-color(primary, tint) !default;

3
core/src/components/radio/radio.tsx
View File

@ -136,8 +136,7 @@ export class Radio implements ComponentInterface {
/** @internal */
@Method()
async setFocus(ev: any) {
// TODO(FW-2832): type (using Event triggers a build error due to conflict with Stencil Event import)
async setFocus(ev: globalThis.Event) {
ev.stopPropagation();
ev.preventDefault();

12
core/src/components/radio/test/legacy/a11y/radio.e2e.ts
View File

@ -6,10 +6,11 @@ import { configs, test } from '@utils/test/playwright';
*/
configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => {
test.describe(title('radio: a11y'), () => {
// TODO(FW-5218)
test.fixme('tabbing should switch between radio groups', async ({ page, pageUtils }) => {
test.beforeEach(async ({ page, skip }) => {
skip.browser('webkit', 'Tabbing is flaky in Safari');
await page.goto(`/src/components/radio/test/legacy/a11y`, config);
});
test('tabbing should switch between radio groups', async ({ page, pageUtils }) => {
const firstGroupRadios = page.locator('#first-group ion-radio');
const secondGroupRadios = page.locator('#second-group ion-radio');
@ -22,10 +23,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
await pageUtils.pressKeys('shift+Tab');
await expect(firstGroupRadios.nth(0)).toBeFocused();
});
// TODO(FW-5218)
test.fixme('using arrow keys should move between enabled radios within group', async ({ page, pageUtils }) => {
await page.goto(`/src/components/radio/test/legacy/a11y`, config);
test('using arrow keys should move between enabled radios within group', async ({ page, pageUtils }) => {
const firstGroupRadios = page.locator('#first-group ion-radio');
await pageUtils.pressKeys('Tab');