javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 00:27:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

test(): remove custom screenshot names (#18022)

Browse Source 
* test(): remove custom screenshot names

* update test names
This commit is contained in:
Liam DeBeasi
2019-04-12 13:02:03 -04:00
committed by GitHub
parent 6e1a8f1df2
commit 1199c53437
13 changed files with 73 additions and 122 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
core/src/components/loading/test/test.utils.ts
View File

@ -1,18 +1,14 @@
import { newE2EPage } from '@stencil/core/testing';
import { cleanScreenshotName, generateE2EUrl } from '../../../utils/test/utils';
import { generateE2EUrl } from '../../../utils/test/utils';
export async function testLoading(
type: string,
selector: string,
rtl = false,
screenshotName: string = cleanScreenshotName(selector)
rtl = false
) {
try {
const pageUrl = generateE2EUrl('loading', type, rtl);
if (rtl) {
screenshotName = `${screenshotName} rtl`;
}
const page = await newE2EPage({
url: pageUrl
@ -28,12 +24,12 @@ export async function testLoading(
await loading.waitForVisible();
screenshotCompares.push(await page.compareScreenshot(screenshotName));
screenshotCompares.push(await page.compareScreenshot());
await loading.callMethod('dismiss');
await loading.waitForNotVisible();
screenshotCompares.push(await page.compareScreenshot(`dismiss ${screenshotName}`));
screenshotCompares.push(await page.compareScreenshot('dismiss'));
loading = await page.find('ion-loading');
expect(loading).toBeNull();