diff --git a/BREAKING.md b/BREAKING.md index 282814ae96..836ec94f64 100644 --- a/BREAKING.md +++ b/BREAKING.md @@ -15,6 +15,7 @@ This is a comprehensive list of the breaking changes introduced in the major ver - [Components](#components) * [Datetime](#datetime) * [Header](#header) + * [Icons](#icons) * [Input](#input) * [Modal](#modal) * [Popover](#popover) @@ -91,6 +92,10 @@ ion-header.header-collapse-condense ion-toolbar:last-of-type { } ``` +#### Icons + +Ionic 6 now ships with Ionicons 6. Please be sure to review the [Ionicons 6.0.0 Changelog](https://github.com/ionic-team/ionicons/releases/tag/v6.0.0) and make any necessary changes. + #### Input The `placeholder` property now has a type of `string | undefined` rather than `null | string | undefined`. diff --git a/angular/src/directives/proxies.ts b/angular/src/directives/proxies.ts index bd054eee3b..4e009a6d68 100644 --- a/angular/src/directives/proxies.ts +++ b/angular/src/directives/proxies.ts @@ -576,13 +576,13 @@ export class IonHeader { export declare interface IonIcon extends Components.IonIcon {} @ProxyCmp({ - inputs: ['ariaHidden', 'ariaLabel', 'color', 'flipRtl', 'icon', 'ios', 'lazy', 'md', 'mode', 'name', 'sanitize', 'size', 'src'] + inputs: ['color', 'flipRtl', 'icon', 'ios', 'lazy', 'md', 'mode', 'name', 'sanitize', 'size', 'src'] }) @Component({ selector: 'ion-icon', changeDetection: ChangeDetectionStrategy.OnPush, template: '', - inputs: ['ariaHidden', 'ariaLabel', 'color', 'flipRtl', 'icon', 'ios', 'lazy', 'md', 'mode', 'name', 'sanitize', 'size', 'src'] + inputs: ['color', 'flipRtl', 'icon', 'ios', 'lazy', 'md', 'mode', 'name', 'sanitize', 'size', 'src'] }) export class IonIcon { protected el: HTMLElement; diff --git a/core/package-lock.json b/core/package-lock.json index 5cd1636f56..33c07a66e0 100644 --- a/core/package-lock.json +++ b/core/package-lock.json @@ -10,7 +10,7 @@ "license": "MIT", "dependencies": { "@stencil/core": "~2.10.0", - "ionicons": "^5.5.4", + "ionicons": "^6.0.0", "tslib": "^2.1.0" }, "devDependencies": { @@ -5549,9 +5549,9 @@ } }, "node_modules/ionicons": { - "version": "5.5.4", - "resolved": "https://registry.npmjs.org/ionicons/-/ionicons-5.5.4.tgz", - "integrity": "sha512-3ph8X9my3inhabWEZ7N0XRA0MnnNQ1v9a602mLNgWsIXnxE9G5BybIZ/pws/OZZ/hoNlvSjk801N03yL9/FNgQ==", + "version": "6.0.0", + "resolved": "https://registry.npmjs.org/ionicons/-/ionicons-6.0.0.tgz", + "integrity": "sha512-p83W1T8jZUlllHAjuIWaDQbI36OYqdrwcf8MhYbKW7+9rjGlCMP9+5OaR0W7tl0QfM004uAiy/zkc7HTpDNKgA==", "dependencies": { "@stencil/core": "~2.10.0" } @@ -18407,9 +18407,9 @@ } }, "ionicons": { - "version": "5.5.4", - "resolved": "https://registry.npmjs.org/ionicons/-/ionicons-5.5.4.tgz", - "integrity": "sha512-3ph8X9my3inhabWEZ7N0XRA0MnnNQ1v9a602mLNgWsIXnxE9G5BybIZ/pws/OZZ/hoNlvSjk801N03yL9/FNgQ==", + "version": "6.0.0", + "resolved": "https://registry.npmjs.org/ionicons/-/ionicons-6.0.0.tgz", + "integrity": "sha512-p83W1T8jZUlllHAjuIWaDQbI36OYqdrwcf8MhYbKW7+9rjGlCMP9+5OaR0W7tl0QfM004uAiy/zkc7HTpDNKgA==", "requires": { "@stencil/core": "~2.10.0" } diff --git a/core/package.json b/core/package.json index 965025582f..db134db041 100644 --- a/core/package.json +++ b/core/package.json @@ -32,7 +32,7 @@ ], "dependencies": { "@stencil/core": "~2.10.0", - "ionicons": "^5.5.4", + "ionicons": "^6.0.0", "tslib": "^2.1.0" }, "devDependencies": { diff --git a/core/src/components/accordion/accordion.tsx b/core/src/components/accordion/accordion.tsx index f21dc9f368..e0466d960d 100644 --- a/core/src/components/accordion/accordion.tsx +++ b/core/src/components/accordion/accordion.tsx @@ -187,7 +187,7 @@ export class Accordion implements ComponentInterface { iconEl.lazy = false; iconEl.classList.add('ion-accordion-toggle-icon'); iconEl.icon = toggleIcon; - iconEl.ariaHidden = 'true'; + iconEl.setAttribute('aria-hidden', 'true'); ionItem.appendChild(iconEl); } diff --git a/packages/react/package.json b/packages/react/package.json index 9e93c98b70..ca6b18b229 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -41,7 +41,7 @@ ], "dependencies": { "@ionic/core": "6.0.0-rc.2", - "ionicons": "^5.5.4", + "ionicons": "^6.0.0", "tslib": "*" }, "peerDependencies": { diff --git a/packages/react/src/components/IonIcon.tsx b/packages/react/src/components/IonIcon.tsx index bb2035b21a..4bec2f5c3c 100644 --- a/packages/react/src/components/IonIcon.tsx +++ b/packages/react/src/components/IonIcon.tsx @@ -7,7 +7,6 @@ import { IonIconInner } from './inner-proxies'; import { createForwardRef, isPlatform } from './utils'; interface IonIconProps { - ariaLabel?: string; color?: string; flipRtl?: boolean; icon?: string; diff --git a/packages/vue/package-lock.json b/packages/vue/package-lock.json index ad6d6971b2..d0aa667467 100644 --- a/packages/vue/package-lock.json +++ b/packages/vue/package-lock.json @@ -9,8 +9,8 @@ "version": "6.0.0-rc.2", "license": "MIT", "dependencies": { - "@ionic/core": "6.0.0-rc.1", - "ionicons": "^5.5.4" + "@ionic/core": "6.0.0-rc.2", + "ionicons": "^6.0.0" }, "devDependencies": { "@stencil/core": "^1.17.0", @@ -53,19 +53,19 @@ } }, "node_modules/@ionic/core": { - "version": "6.0.0-rc.1", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.0.0-rc.1.tgz", - "integrity": "sha512-O7kqodTo61gJKaeokYcdM5KwnfZ1Li5UiBbQH5oZXeU0jzJWfp5dU02Chk3dCMlMI1dUYmQRnu2KCwETV/X5Kg==", + "version": "6.0.0-rc.2", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.0.0-rc.2.tgz", + "integrity": "sha512-evf3J01B91zs386bBYz55zjG0I7BXSs/+pySkj+fDHVT/teXYntpUzebm5rqA0/IoUn6QXEdz1x3Nrz8040/Jg==", "dependencies": { - "@stencil/core": "^2.6.0", - "ionicons": "^5.5.1", + "@stencil/core": "~2.10.0", + "ionicons": "^5.5.4", "tslib": "^2.1.0" } }, "node_modules/@ionic/core/node_modules/@stencil/core": { - "version": "2.6.0", - "resolved": "https://registry.npmjs.org/@stencil/core/-/core-2.6.0.tgz", - "integrity": "sha512-QsxWayZyusnqSZrlCl81R71rA3KqFjVVQSH4E0rGN15F1GdQaFonKlHLyCOLKLig1zzC+DQkLLiUuocexuvdeQ==", + "version": "2.10.0", + "resolved": "https://registry.npmjs.org/@stencil/core/-/core-2.10.0.tgz", + "integrity": "sha512-15rWMTPQ/sp0lSV82HVCXkIya3QLN+uBl7pqK4JnTrp4HiLrzLmNbWjbvgCs55gw0lULbCIGbRIEsFz+Pe/Q+A==", "bin": { "stencil": "bin/stencil" }, @@ -74,6 +74,14 @@ "npm": ">=6.0.0" } }, + "node_modules/@ionic/core/node_modules/ionicons": { + "version": "5.5.4", + "resolved": "https://registry.npmjs.org/ionicons/-/ionicons-5.5.4.tgz", + "integrity": "sha512-3ph8X9my3inhabWEZ7N0XRA0MnnNQ1v9a602mLNgWsIXnxE9G5BybIZ/pws/OZZ/hoNlvSjk801N03yL9/FNgQ==", + "dependencies": { + "@stencil/core": "~2.10.0" + } + }, "node_modules/@ionic/core/node_modules/tslib": { "version": "2.2.0", "resolved": "https://registry.npmjs.org/tslib/-/tslib-2.2.0.tgz", @@ -356,9 +364,9 @@ "dev": true }, "node_modules/ionicons": { - "version": "5.5.4", - "resolved": "https://registry.npmjs.org/ionicons/-/ionicons-5.5.4.tgz", - "integrity": "sha512-3ph8X9my3inhabWEZ7N0XRA0MnnNQ1v9a602mLNgWsIXnxE9G5BybIZ/pws/OZZ/hoNlvSjk801N03yL9/FNgQ==", + "version": "6.0.0", + "resolved": "https://registry.npmjs.org/ionicons/-/ionicons-6.0.0.tgz", + "integrity": "sha512-p83W1T8jZUlllHAjuIWaDQbI36OYqdrwcf8MhYbKW7+9rjGlCMP9+5OaR0W7tl0QfM004uAiy/zkc7HTpDNKgA==", "dependencies": { "@stencil/core": "~2.10.0" } @@ -633,19 +641,27 @@ } }, "@ionic/core": { - "version": "6.0.0-rc.1", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.0.0-rc.1.tgz", - "integrity": "sha512-O7kqodTo61gJKaeokYcdM5KwnfZ1Li5UiBbQH5oZXeU0jzJWfp5dU02Chk3dCMlMI1dUYmQRnu2KCwETV/X5Kg==", + "version": "6.0.0-rc.2", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.0.0-rc.2.tgz", + "integrity": "sha512-evf3J01B91zs386bBYz55zjG0I7BXSs/+pySkj+fDHVT/teXYntpUzebm5rqA0/IoUn6QXEdz1x3Nrz8040/Jg==", "requires": { - "@stencil/core": "^2.6.0", - "ionicons": "^5.5.1", + "@stencil/core": "~2.10.0", + "ionicons": "^5.5.4", "tslib": "^2.1.0" }, "dependencies": { "@stencil/core": { - "version": "2.6.0", - "resolved": "https://registry.npmjs.org/@stencil/core/-/core-2.6.0.tgz", - "integrity": "sha512-QsxWayZyusnqSZrlCl81R71rA3KqFjVVQSH4E0rGN15F1GdQaFonKlHLyCOLKLig1zzC+DQkLLiUuocexuvdeQ==" + "version": "2.10.0", + "resolved": "https://registry.npmjs.org/@stencil/core/-/core-2.10.0.tgz", + "integrity": "sha512-15rWMTPQ/sp0lSV82HVCXkIya3QLN+uBl7pqK4JnTrp4HiLrzLmNbWjbvgCs55gw0lULbCIGbRIEsFz+Pe/Q+A==" + }, + "ionicons": { + "version": "5.5.4", + "resolved": "https://registry.npmjs.org/ionicons/-/ionicons-5.5.4.tgz", + "integrity": "sha512-3ph8X9my3inhabWEZ7N0XRA0MnnNQ1v9a602mLNgWsIXnxE9G5BybIZ/pws/OZZ/hoNlvSjk801N03yL9/FNgQ==", + "requires": { + "@stencil/core": "~2.10.0" + } }, "tslib": { "version": "2.2.0", @@ -904,9 +920,9 @@ "dev": true }, "ionicons": { - "version": "5.5.4", - "resolved": "https://registry.npmjs.org/ionicons/-/ionicons-5.5.4.tgz", - "integrity": "sha512-3ph8X9my3inhabWEZ7N0XRA0MnnNQ1v9a602mLNgWsIXnxE9G5BybIZ/pws/OZZ/hoNlvSjk801N03yL9/FNgQ==", + "version": "6.0.0", + "resolved": "https://registry.npmjs.org/ionicons/-/ionicons-6.0.0.tgz", + "integrity": "sha512-p83W1T8jZUlllHAjuIWaDQbI36OYqdrwcf8MhYbKW7+9rjGlCMP9+5OaR0W7tl0QfM004uAiy/zkc7HTpDNKgA==", "requires": { "@stencil/core": "~2.10.0" }, diff --git a/packages/vue/package.json b/packages/vue/package.json index 09fe068892..7133d8cd4f 100644 --- a/packages/vue/package.json +++ b/packages/vue/package.json @@ -60,7 +60,7 @@ }, "dependencies": { "@ionic/core": "6.0.0-rc.2", - "ionicons": "^5.5.4" + "ionicons": "^6.0.0" }, "vetur": { "tags": "dist/vetur/tags.json", diff --git a/packages/vue/src/components/IonIcon.ts b/packages/vue/src/components/IonIcon.ts index 04dd5daa01..4bcc75c992 100644 --- a/packages/vue/src/components/IonIcon.ts +++ b/packages/vue/src/components/IonIcon.ts @@ -6,7 +6,6 @@ import { IonIcon as IonIconCmp } from 'ionicons/components/ion-icon.js'; export const IonIcon = /*@__PURE__*/ defineComponent({ name: 'IonIcon', props: { - ariaLabel: String, color: String, flipRtl: Boolean, icon: String,