From 11425fbb35330e0e0f483d902d8cca56694d7ecf Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Wed, 17 Nov 2021 15:16:22 +0000 Subject: [PATCH] build(): ensure react router gets latest version of core --- .../actions/build-react-router/action.yml | 18 +++++++++--------- packages/react-router/package.json | 1 - 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/.github/workflows/actions/build-react-router/action.yml b/.github/workflows/actions/build-react-router/action.yml index 7fe4b6c8f6..062fda3a5c 100644 --- a/.github/workflows/actions/build-react-router/action.yml +++ b/.github/workflows/actions/build-react-router/action.yml @@ -14,20 +14,20 @@ runs: with: path: ./core/node_modules key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('./core/package-lock.json') }}-v1 - - name: Install Dependencies - run: npm install --legacy-peer-deps - shell: bash - working-directory: ./packages/react-router - - uses: ./.github/workflows/actions/download-archive - with: - name: ionic-react - path: ./packages/react - filename: ReactBuild.zip - uses: ./.github/workflows/actions/download-archive with: name: ionic-core path: ./core filename: CoreBuild.zip + - uses: ./.github/workflows/actions/download-archive + with: + name: ionic-react + path: ./packages/react + filename: ReactBuild.zip + - name: Install Dependencies + run: npm install --legacy-peer-deps + shell: bash + working-directory: ./packages/react-router - name: Sync run: npm run sync shell: bash diff --git a/packages/react-router/package.json b/packages/react-router/package.json index 5642721dd9..19e7f4a5eb 100644 --- a/packages/react-router/package.json +++ b/packages/react-router/package.json @@ -47,7 +47,6 @@ "react-router-dom": "^5.0.1" }, "devDependencies": { - "@ionic/core": "5.9.0", "@ionic/react": "5.8.5", "@rollup/plugin-node-resolve": "^8.1.0", "@testing-library/jest-dom": "^5.11.6",