From 0fcd34e464d969f1040195ddd9ee6ab3cd298b76 Mon Sep 17 00:00:00 2001 From: mhartington Date: Wed, 28 Feb 2018 12:25:03 -0500 Subject: [PATCH] fix(): menu button and nav overflow --- packages/core/src/components/menu-button/menu-button.tsx | 2 ++ packages/core/src/components/nav/nav.scss | 1 + 2 files changed, 3 insertions(+) diff --git a/packages/core/src/components/menu-button/menu-button.tsx b/packages/core/src/components/menu-button/menu-button.tsx index 7f9c662a28..85ac6978a7 100644 --- a/packages/core/src/components/menu-button/menu-button.tsx +++ b/packages/core/src/components/menu-button/menu-button.tsx @@ -40,6 +40,8 @@ export class MenuButton { componentWillLoad() { this.custom = this.el.childElementCount > 0; + const closestNav = this.el.closest('ion-nav'); + closestNav.canGoBack() ? this.el.hidden = true : this.el.hidden = false; } render() { diff --git a/packages/core/src/components/nav/nav.scss b/packages/core/src/components/nav/nav.scss index 4bdc326f49..0e9fd5351a 100644 --- a/packages/core/src/components/nav/nav.scss +++ b/packages/core/src/components/nav/nav.scss @@ -9,6 +9,7 @@ ion-nav { z-index: $z-index-page-container; + overflow: hidden; width: 100%; height: 100%;