From 0e63850a8f4b901a86ee129d56e48bab01af4d6c Mon Sep 17 00:00:00 2001 From: Adam Bradley Date: Tue, 12 May 2015 21:15:54 -0500 Subject: [PATCH] nav wip --- gulpfile.js | 3 --- ionic/components/nav/nav-item.js | 5 +++-- ionic/components/nav/nav.js | 22 +++++++++++-------- .../nav/test/basic/pages/first-page.js | 7 +++--- .../nav/test/basic/pages/third-page.js | 2 +- ionic/transitions/none-transition.js | 8 +++---- 6 files changed, 24 insertions(+), 23 deletions(-) diff --git a/gulpfile.js b/gulpfile.js index e90bb91b73..709d337501 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -18,9 +18,6 @@ var watch = require('gulp-watch'); var exec = require('child_process').exec; -// !!! TEMP HACK !!! -// first run ./update-angular.sh - gulp.task('build', function() { runSequence( 'clean', diff --git a/ionic/components/nav/nav-item.js b/ionic/components/nav/nav-item.js index e065543c5e..f263c3cba5 100644 --- a/ionic/components/nav/nav-item.js +++ b/ionic/components/nav/nav-item.js @@ -19,10 +19,11 @@ export class NavItem { let injector = null; - this.nav.loader.loadIntoExistingLocation(this.Class, this.nav.itemContent.elementRef, injector) + this.nav.loader.loadNextToExistingLocation(this.Class, this.nav.itemContent.elementRef, injector) .then((componentRef) => { - console.log('Component loadIntoExistingLocation completed') + this.component = componentRef; + this.domElement = componentRef.location.domElement; resolve(); }); diff --git a/ionic/components/nav/nav.js b/ionic/components/nav/nav.js index fe22d37b03..1604e8a4e0 100644 --- a/ionic/components/nav/nav.js +++ b/ionic/components/nav/nav.js @@ -17,13 +17,13 @@ import {ToolbarContainer} from 'ionic/components/toolbar/toolbar'; }) @View({ template: ` -
+ -