diff --git a/CHANGELOG.md b/CHANGELOG.md index a0f68f2cfb..0d84562475 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,15 @@ +## [4.8.1](https://github.com/ionic-team/ionic/compare/v4.8.0...v4.8.1) (2019-08-27) + + +### Bug Fixes + +* **animation:** enable backwards compatibility for overlay animations ([#19160](https://github.com/ionic-team/ionic/issues/19160)) ([fb70980](https://github.com/ionic-team/ionic/commit/fb70980)) +* **gesture:** account for negative step values with Web Animations ([#19196](https://github.com/ionic-team/ionic/issues/19196)) ([b3c7436](https://github.com/ionic-team/ionic/commit/b3c7436)) +* **ios:** clear opacity on toolbar background after iOS transition ([#19169](https://github.com/ionic-team/ionic/issues/19169)) ([fa958a5](https://github.com/ionic-team/ionic/commit/fa958a5)) +* **md:** set fill mode on MD transition to `both` ([#19161](https://github.com/ionic-team/ionic/issues/19161)) ([0e8ab49](https://github.com/ionic-team/ionic/commit/0e8ab49)) + + + # [4.8.0 Oxygen](https://github.com/ionic-team/ionic/compare/v4.7.4...v4.8.0) (2019-08-21) diff --git a/angular/package.json b/angular/package.json index 75e0fef7f2..2cc5e5c9a5 100644 --- a/angular/package.json +++ b/angular/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/angular", - "version": "4.8.0", + "version": "4.8.1", "description": "Angular specific wrappers for @ionic/core", "keywords": [ "ionic", @@ -49,7 +49,7 @@ "css/" ], "dependencies": { - "@ionic/core": "4.8.0", + "@ionic/core": "4.8.1", "tslib": "^1.9.3" }, "peerDependencies": { diff --git a/core/package.json b/core/package.json index 4d1cc894df..4998685c9b 100644 --- a/core/package.json +++ b/core/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/core", - "version": "4.8.0", + "version": "4.8.1", "description": "Base components for Ionic", "keywords": [ "ionic", diff --git a/core/src/components/menu/menu.tsx b/core/src/components/menu/menu.tsx index 8c55a51581..f085484dd6 100644 --- a/core/src/components/menu/menu.tsx +++ b/core/src/components/menu/menu.tsx @@ -416,6 +416,14 @@ export class Menu implements ComponentInterface, MenuI { // Account for rounding errors in JS let newStepValue = (shouldComplete) ? 0.001 : -0.001; + /** + * TODO: stepValue can sometimes return a negative + * value, but you can't have a negative time value + * for the cubic bezier curve (at least with web animations) + * Not sure if the negative step value is an error or not + */ + const adjustedStepValue = (stepValue <= 0) ? 0.01 : stepValue; + /** * Animation will be reversed here, so need to * reverse the easing curve as well @@ -424,7 +432,7 @@ export class Menu implements ComponentInterface, MenuI { * to the new easing curve, as `stepValue` is going to be given * in terms of a linear curve. */ - newStepValue += getTimeGivenProgression(new Point(0, 0), new Point(0.4, 0), new Point(0.6, 1), new Point(1, 1), stepValue); + newStepValue += getTimeGivenProgression(new Point(0, 0), new Point(0.4, 0), new Point(0.6, 1), new Point(1, 1), adjustedStepValue); this.animation .easing('cubic-bezier(0.4, 0.0, 0.6, 1)') diff --git a/core/src/utils/gesture/swipe-back.ts b/core/src/utils/gesture/swipe-back.ts index 5c7a96afd6..3ac10df3a3 100644 --- a/core/src/utils/gesture/swipe-back.ts +++ b/core/src/utils/gesture/swipe-back.ts @@ -37,7 +37,13 @@ export const createSwipeBackGesture = ( realDur = Math.min(dur, 540); } - onEndHandler(shouldComplete, stepValue, realDur); + /** + * TODO: stepValue can sometimes return a negative + * value, but you can't have a negative time value + * for the cubic bezier curve (at least with web animations) + * Not sure if the negative step value is an error or not + */ + onEndHandler(shouldComplete, (stepValue <= 0) ? 0.01 : stepValue, realDur); }; return createGesture({ diff --git a/docs/package.json b/docs/package.json index 94257da652..e159b705b2 100644 --- a/docs/package.json +++ b/docs/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/docs", - "version": "4.8.0", + "version": "4.8.1", "description": "Pre-packaged API documentation for the Ionic docs.", "main": "core.json", "files": [